6502/mre-mos6502
1
0
Fork 0
mirror of https://github.com/mre/mos6502.git synced 2024-11-30 20:51:21 +00:00
Code Issues Projects Releases Wiki Activity

set_byte method does not need to return old_value

Browse Source
This commit is contained in:
Sam M W 2023-04-03 22:44:02 +01:00
parent d2043dc6fb
commit 26926a9feb
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/memory.rs
View File

@ -60,7 +60,7 @@ impl Default for Memory {
pub trait Bus { pub trait Bus {
fn get_byte(&self, address: u16) -> u8; fn get_byte(&self, address: u16) -> u8;
fn set_byte(&mut self, address: u16, value: u8) -> u8; fn set_byte(&mut self, address: u16, value: u8);
fn set_bytes(&mut self, start: u16, values: &[u8]) { fn set_bytes(&mut self, start: u16, values: &[u8]) {
for i in 0..values.len() as u16 { for i in 0..values.len() as u16 {
@ -84,10 +84,8 @@ impl Bus for Memory {
// Sets the byte at the given address to the given value and returns the // Sets the byte at the given address to the given value and returns the
// previous value at the address. // previous value at the address.
fn set_byte(&mut self, address: u16, value: u8) -> u8 { fn set_byte(&mut self, address: u16, value: u8) {
let old_value = self.get_byte(address);
self.bytes[address as usize] = value; self.bytes[address as usize] = value;
old_value
} }
fn set_bytes(&mut self, start: u16, values: &[u8]) { fn set_bytes(&mut self, start: u16, values: &[u8]) {