Apple-2-HW/unified_retro_keyboard
1
0
Fork 0
mirror of https://github.com/osiweb/unified_retro_keyboard.git synced 2024-11-25 09:31:11 +00:00
Code Issues Projects Releases Wiki Activity

BugFix: asdf_buffer_get: check for valid handle

Browse Source 
Was only testing for handle less than next_handle, but not checking for
negative handle values. Fixed to use buffer_handle_valid() to test for a
valid handle.
This commit is contained in:
David Fenyes 2021-12-14 11:31:39 -06:00
parent 118065236b
commit e13c9d6888
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/asdf/src/asdf_buffer.c
View File

@ -193,7 +193,7 @@ void asdf_buffer_put(asdf_buffer_handle_t handle, asdf_keycode_t code)
asdf_keycode_t asdf_buffer_get(asdf_buffer_handle_t handle) asdf_keycode_t asdf_buffer_get(asdf_buffer_handle_t handle)
{ {
asdf_keycode_t code = ASDF_INVALID_CODE; asdf_keycode_t code = ASDF_INVALID_CODE;
if (handle < next_handle && buffers[handle].count) { if (buffer_handle_valid(handle) && buffers[handle].count) {
code = buffers[handle].buf[buffers[handle].tail]; code = buffers[handle].buf[buffers[handle].tail];
buffers[handle].tail = (buffers[handle].tail + 1) % buffers[handle].size; buffers[handle].tail = (buffers[handle].tail + 1) % buffers[handle].size;
buffers[handle].count--; buffers[handle].count--;