mirror of
https://github.com/oliverschmidt/contiki.git
synced 2024-12-22 10:30:13 +00:00
cc2538: gpio: Fix missed interrupts
Only the interrupt flags that have been handled must be cleared. Otherwise, if a new interrupt occurs after the interrupt statuses are read and before they are cleared, then it is discarded without having been handled. This issue was particularly likely with two interrupt trigger conditions occurring on different pins of the same port in a short period of time. Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
This commit is contained in:
parent
1a5632cba0
commit
3d9d52de87
@ -86,18 +86,20 @@ static void
|
||||
gpio_port_isr(uint8_t port)
|
||||
{
|
||||
uint32_t base;
|
||||
uint8_t int_status, power_up_int_status;
|
||||
|
||||
lpm_exit();
|
||||
|
||||
ENERGEST_ON(ENERGEST_TYPE_IRQ);
|
||||
|
||||
base = GPIO_PORT_TO_BASE(port);
|
||||
int_status = GPIO_GET_MASKED_INT_STATUS(base);
|
||||
power_up_int_status = GPIO_GET_POWER_UP_INT_STATUS(port);
|
||||
|
||||
notify(GPIO_GET_MASKED_INT_STATUS(base) | GPIO_GET_POWER_UP_INT_STATUS(port),
|
||||
port);
|
||||
notify(int_status | power_up_int_status, port);
|
||||
|
||||
GPIO_CLEAR_INTERRUPT(base, 0xFF);
|
||||
GPIO_CLEAR_POWER_UP_INTERRUPT(port, 0xFF);
|
||||
GPIO_CLEAR_INTERRUPT(base, int_status);
|
||||
GPIO_CLEAR_POWER_UP_INTERRUPT(port, power_up_int_status);
|
||||
|
||||
ENERGEST_OFF(ENERGEST_TYPE_IRQ);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user