Commit Graph

5 Commits

Author SHA1 Message Date
T. Joseph Carter
b55ea886c1 Style cleanup to diskimg.py
This is still a good ways from "proper" because this code is still kinda not
really done.
2017-07-21 14:21:53 -07:00
T. Joseph Carter
22b290e3ca Remove 2img code, use ByteBuffer instead
One thing both AppleCommander and CiderPress do is wrap 2img is effectively
treat 2img files as containers.  That's a good idea.  We need to start using our
buffer code before it begins making sense, but that means this 2img code has to
go as it's kind of just bolted on to the side for now.

Instead we'll put the image we load into a buffer.  How we do that is likely to
change, but this gets us to the point we can start using it.
2017-07-19 22:29:09 -07:00
T. Joseph Carter
894225d1fa Use LOG, move logging setup to cppo
The actual logging configuration belongs in the application, not a module.  In a
module, it's always going to do what the module says to do.  And that's fine for
cppo which is a script that works the way it does, but we have bigger plans for
this code.  It's now in the cppo module.

We've stopped using log from blocksfree.logging, favoring LOG instead, so we
have removed it.
2017-07-18 18:19:57 -07:00
T. Joseph Carter
1d4ee00658 Consistent copyright notices 2017-07-08 07:48:30 -07:00
T. Joseph Carter
6bb27a028f Broke diskimg.py out of legacy
I may not have done this 100% "properly"--this is really the first full
application thingy I've ever tried to write in Python.  I learned circular
imports are possible and the error messages are not obvious when you do that.

I've also learned that importing a package doesn't necessarily import the
modules within that package--if you want that, the package needs to import its
submodules into itself.  That was not obvious either.  It does explain why
sometimes you must import subpackages directly and other times importing the
package is all you need.  This is probably obvious to Python developers who
actually work on big projects, but ... I've only ever done single-file scripts
before now so it wasn't obvious to me.

For now, blocksfree is importing legacy.  We don't have enough outside of
legacy yet to make the alternative even remotely useful at this time.
Eventually though the goal is to stop doing that.
2017-07-08 05:52:34 -07:00