From 8a3c40d6fd4e1f0674cc70131ba0f5d798612a09 Mon Sep 17 00:00:00 2001 From: Michel Pollet Date: Sat, 28 Oct 2023 06:11:51 +0100 Subject: [PATCH] Fixed Compiling.md Typos mostly Signed-off-by: Michel Pollet --- docs/Compiling.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/Compiling.md b/docs/Compiling.md index 652f20a..ad419c9 100644 --- a/docs/Compiling.md +++ b/docs/Compiling.md @@ -6,18 +6,19 @@ * libx11-dev * Many of them will probably be installed already if you regulargly compile stuff. * Then just type `make` and it should compile. - * To run it, just type `build-x86_64-linux-gnu/bin/bin/mii_emu` and it should start. + * To run it, just type `build-x86_64-linux-gnu/bin/mii_emu` and it should start. ## Development * This is the first project I made using vscode as my main IDE; I used Eclipse for many years as the indexer was pretty much unbeatable (still is). * To support vscode I needed some tooling to create the '*compile_commands.json*' file, which is used by the C/C++ extension to provide intellisense. So to create that file, you use `make lsp` and it will create the file in the project directory. -* Another thing vscode sucks at is Makefiles (despite the extension, building is painful and next to useless). So there is a target called `make watch` that you can run in a separate terminal to auto-build as soon as you same any files in vscode. That is when you realize for example that vscode re-save the file anytime you press control-S, regardless of wether the file has changed or not. So you end up with a lot of unnecessary builds. I'm sure there is a way to fix that, but I haven't found it yet. +* Another thing vscode sucks at is Makefiles (despite the extension, building is painful and next to useless). So there is a target called `make watch` that you can run in a separate terminal to auto-build as soon as you save any files in vscode. That is when you realize for example that vscode re-save the file anytime you press control-S, regardless of wether the file has changed or not. So you end up with a lot of unnecessary builds. I'm sure there is a way to fix that, but I haven't found it yet. ## Code Style I have pretty consistent code style across my projects. * tabs=4. Just because. * 80 columns lines or so. I don't like to scroll horizontally and I like splitting my screen vertically. (also see, tabs=4!). * K&R style exclusively. None of that Allman/GNU horribleness. +* GNU99 Dialect. * No Yoda, we are no longer in 1975. `if (0 == foo)` is just stupid. * I use !! to convert to 1 or zero from an expression. I call it the 'normalisation operator'. it is not commonly seen, apart from places like the Linux kernel. * I use *minipt.h* for protothreads. I like protothreads, and when you are aware of their limitations, they are a great tool. They are used for the video rendering, the no-slot-clock etc. @@ -30,4 +31,4 @@ I have pretty consistent code style across my projects. * The floppy drive emulation was borrowed from bobbin, and it works, and it got it all working, but it's definitely not matching the style of the rest of the codebase. It needs to be replaced. * Plenty of the most complicated piece of code (video, memory mapping) load a dozen of soft-switches, it probably should use a separately maintained bit field that is maintained by the on/off switches, and would make it a lot easier to test for bit combinations. - * The static array of memory 'banks' works, but it prevents me easily making a memory extension card. It should be refactored at some point. \ No newline at end of file + * The static array of memory 'banks' works, but it prevents me easily making a memory extension card. It should be refactored at some point.