Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2025-02-16 22:30:46 +00:00
Code Issues Projects Releases Wiki Activity

Revert "ir: SCC now sets all bits to 1 (or 0)"

Browse Source 
This reverts commit 7245aece4fa16a7054e7bc876a44c9f47d71bbe9.
This commit is contained in:
Irmen de Jong 2023-07-09 22:51:16 +02:00
parent e98bbc1c52
commit a98cb50d55
3 changed files with 26 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/source/todo.rst
View File

@ -1,7 +1,7 @@
TODO
====
- IR/VM: fix the vm/textelite game, it now prints garbage! (caused by the SGE opcode implementation change to set -1 instead of 1)
- VM: fix endless loop n=0 :: for i in 5 downto n (fine for n=1) (wrong for bytes and words)
- IR: instructions that do type conversion (SZ etc, CONCAT, SGN) should put the result in a DIFFERENT register.

25
intermediate/src/prog8/intermediate/IRInstructions.kt
View File

@ -97,18 +97,19 @@ bgesr reg1, reg2, address - jump to location in program given by l
ble reg1, value, address - jump to location in program given by location, if reg1 <= immediate value (unsigned)
bles reg1, value, address - jump to location in program given by location, if reg1 <= immediate value (signed)
( NOTE: there are no bltr/bler instructions because these are equivalent to bgtr/bger with the register operands swapped around.)
sz reg1, reg2 - set reg1=-1 (all bits one) if reg2==0, else 0
snz reg1, reg2 - set reg1=-1 (all bits one) if reg2!=0, else 0
seq reg1, reg2 - set reg1=-1 (all bits one) if reg1 == reg2, else 0
sne reg1, reg2 - set reg1=-1 (all bits one) if reg1 != reg2, else 0
slt reg1, reg2 - set reg1=-1 (all bits one) if reg1 < reg2 (unsigned), else 0
slts reg1, reg2 - set reg1=-1 (all bits one) if reg1 < reg2 (signed), else 0
sle reg1, reg2 - set reg1=-1 (all bits one) if reg1 <= reg2 (unsigned), else 0
sles reg1, reg2 - set reg1=-1 (all bits one) if reg1 <= reg2 (signed), else 0
sgt reg1, reg2 - set reg1=-1 (all bits one) if reg1 > reg2 (unsigned), else 0
sgts reg1, reg2 - set reg1=-1 (all bits one) if reg1 > reg2 (signed), else 0
sge reg1, reg2 - set reg1=-1 (all bits one) if reg1 >= reg2 (unsigned), else 0
sges reg1, reg2 - set reg1=-1 (all bits one) if reg1 >= reg2 (signed), else 0
sz reg1, reg2 - set reg1=1 if reg2==0, else 0
snz reg1, reg2 - set reg1=1 if reg2!=0, else 0
seq reg1, reg2 - set reg1=1 if reg1 == reg2, else 0
sne reg1, reg2 - set reg1=1 if reg1 != reg2, else 0
slt reg1, reg2 - set reg1=1 if reg1 < reg2 (unsigned), else 0
slts reg1, reg2 - set reg1=1 if reg1 < reg2 (signed), else 0
sle reg1, reg2 - set reg1=1 if reg1 <= reg2 (unsigned), else 0
sles reg1, reg2 - set reg1=1 if reg1 <= reg2 (signed), else 0
sgt reg1, reg2 - set reg1=1 if reg1 > reg2 (unsigned), else 0
sgts reg1, reg2 - set reg1=1 if reg1 > reg2 (signed), else 0
sge reg1, reg2 - set reg1=1 if reg1 >= reg2 (unsigned), else 0
sges reg1, reg2 - set reg1=1 if reg1 >= reg2 (signed), else 0
(note: on the M68k these instructions will set all bits to 1 (so value=-1 instead of 1), but the boolean logic here requires it to be 0 or 1 in this IR)
ARITHMETIC

24
virtualmachine/src/prog8/vm/VirtualMachine.kt
View File

@ -808,84 +808,84 @@ class VirtualMachine(irProgram: IRProgram) {
private fun InsSZ(i: IRInstruction) {
val (_: Int, right: Int) = getSetOnConditionOperands(i)
val value = if(right==0) -1 else 0
val value = if(right==0) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSNZ(i: IRInstruction) {
val (_: Int, right: Int) = getSetOnConditionOperands(i)
val value = if(right!=0) -1 else 0
val value = if(right!=0) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSEQ(i: IRInstruction) {
val (left: Int, right: Int) = getSetOnConditionOperands(i)
val value = if(left==right) -1 else 0
val value = if(left==right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSNE(i: IRInstruction) {
val (left: Int, right: Int) = getSetOnConditionOperands(i)
val value = if(left!=right) -1 else 0
val value = if(left!=right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSLT(i: IRInstruction) {
val (left, right) = getSetOnConditionOperandsU(i)
val value = if(left<right) -1 else 0
val value = if(left<right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSLTS(i: IRInstruction) {
val (left, right) = getSetOnConditionOperands(i)
val value = if(left<right) -1 else 0
val value = if(left<right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSGT(i: IRInstruction) {
val (left, right) = getSetOnConditionOperandsU(i)
val value = if(left>right) -1 else 0
val value = if(left>right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSGTS(i: IRInstruction) {
val (left, right) = getSetOnConditionOperands(i)
val value = if(left>right) -1 else 0
val value = if(left>right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSLE(i: IRInstruction) {
val (left, right) = getSetOnConditionOperandsU(i)
val value = if(left<=right) -1 else 0
val value = if(left<=right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSLES(i: IRInstruction) {
val (left, right) = getSetOnConditionOperands(i)
val value = if(left<=right) -1 else 0
val value = if(left<=right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSGE(i: IRInstruction) {
val (left, right) = getSetOnConditionOperandsU(i)
val value = if(left>=right) -1 else 0
val value = if(left>=right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()
}
private fun InsSGES(i: IRInstruction) {
val (left, right) = getSetOnConditionOperands(i)
val value = if(left>=right) -1 else 0
val value = if(left>=right) 1 else 0
setResultReg(i.reg1!!, value, i.type!!)
nextPc()