extend uninit fix to Apple Cider Spider demo, and add comments

2025-04-08 23:38:22 +00:00 · 2025-01-10 10:46:34 -05:00 · 2025-01-10 10:46:34 -05:00 · 047b0e9277
commit 047b0e9277
parent da85fe8fcd
44 changed files with 44 additions and 43 deletions
--- a/res/history.md
+++ b/res/history.md
@ -15,6 +15,7 @@

 - Fix crash in Black Magic on Apple //c+ (closes [633](https://github.com/a2-4am/4cade/issues/633))
 - Fix quit option in Angry Birds (closes [636](https://github.com/a2-4am/4cade/issues/636))
+- Fix uninitialized value in Apple Cider Spider and its self-running demo
 - Improve joystick handling in Frogger II (closes [658](https://github.com/a2-4am/4cade/issues/658))
 - Properly reset Mockingboard speech chip on Ctrl-Reset (closes [660](https://github.com/a2-4am/4cade/issues/660))
 - Improve Mockingboard speech detection algorithm (closes [661](https://github.com/a2-4am/4cade/issues/661))
@ -22,7 +23,6 @@
 - Remove false positive on A2FPGA which made it look like it supported Mockingboard speech even though it doesn't
 - Mark Mapple and Crime Wave as having in-game cheats
 - Remove debugging code from Mapple
- Fix Angry Birds quit
 - Improve compatibility on machines running ROMx custom ROM and booting from BOOTi mass storage device
 - Add more game help (thanks Brendan R., Andrew R.)

--- a/src/demo/cider.spider.a
+++ b/src/demo/cider.spider.a
@ -23,6 +23,7 @@
         bpl   -

         inx
+         stx   $306       ; uninitialized value in original game
         stx   $10AC
         inx
         stx   $10B1      ; reset vector patch
--- a/src/index/artwork.idx.a
+++ b/src/index/artwork.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16010957
+         !be24  16010960
         !le16     5129
--- a/src/index/attract.idx.a
+++ b/src/index/attract.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15948820
+         !be24  15948823
         !le16     5807
--- a/src/index/cache00.idx.a
+++ b/src/index/cache00.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15880373
+         !be24  15880376
         !le16     4171
--- a/src/index/cache01.idx.a
+++ b/src/index/cache01.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15895068
+         !be24  15895071
         !le16     4642
--- a/src/index/cache10.idx.a
+++ b/src/index/cache10.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15913830
+         !be24  15913833
         !le16     5617
--- a/src/index/cache11.idx.a
+++ b/src/index/cache11.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15934986
+         !be24  15934989
         !le16     6209
--- a/src/index/coverfade.idx.a
+++ b/src/index/coverfade.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16016086
+         !be24  16016089
         !le16      410
--- a/src/index/credits.idx.a
+++ b/src/index/credits.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16016840
+         !be24  16016843
         !le16      449
--- a/src/index/decrunch.idx.a
+++ b/src/index/decrunch.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16017289
+         !be24  16017292
         !le16      309
--- a/src/index/demo.idx.a
+++ b/src/index/demo.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15954627
+         !be24  15954630
         !le16     1757
--- a/src/index/dfx.idx.a
+++ b/src/index/dfx.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15963424
+         !be24  15963427
         !le16     1640
--- a/src/index/dgr.fizzle.idx.a
+++ b/src/index/dgr.fizzle.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16016572
+         !be24  16016575
         !le16       67
--- a/src/index/dgr.idx.a
+++ b/src/index/dgr.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16010898
+         !be24  16010901
         !le16       59
--- a/src/index/dhgr.idx.a
+++ b/src/index/dhgr.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16009234
+         !be24  16009237
         !le16     1510
--- a/src/index/dtitle.idx.a
+++ b/src/index/dtitle.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15993982
+         !be24  15993985
         !le16      590
--- a/src/index/fx.idx.a
+++ b/src/index/fx.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15960784
+         !be24  15960787
         !le16     2640
--- a/src/index/fxcode.idx.a
+++ b/src/index/fxcode.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15965422
+         !be24  15965425
         !le16      246
--- a/src/index/fxdata.idx.a
+++ b/src/index/fxdata.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15965668
+         !be24  15965671
         !le16      538
--- a/src/index/gamehelp.idx.a
+++ b/src/index/gamehelp.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15966206
+         !be24  15966209
         !le16     7625
--- a/src/index/gr.fizzle.idx.a
+++ b/src/index/gr.fizzle.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16016496
+         !be24  16016499
         !le16       76
--- a/src/index/gr.idx.a
+++ b/src/index/gr.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16010744
+         !be24  16010747
         !le16      154
--- a/src/index/helptext.idx.a
+++ b/src/index/helptext.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16016639
+         !be24  16016642
         !le16      201
--- a/src/index/hgr0.idx.a
+++ b/src/index/hgr0.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15994572
+         !be24  15994575
         !le16     4334
--- a/src/index/hgr1.idx.a
+++ b/src/index/hgr1.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15998906
+         !be24  15998909
         !le16     1733
--- a/src/index/hgr2.idx.a
+++ b/src/index/hgr2.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16000639
+         !be24  16000642
         !le16     1194
--- a/src/index/hgr3.idx.a
+++ b/src/index/hgr3.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16001833
+         !be24  16001836
         !le16     3441
--- a/src/index/hgr4.idx.a
+++ b/src/index/hgr4.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16005274
+         !be24  16005277
         !le16     3429
--- a/src/index/hgr5.idx.a
+++ b/src/index/hgr5.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16008703
+         !be24  16008706
         !le16      404
--- a/src/index/hgr6.idx.a
+++ b/src/index/hgr6.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16009107
+         !be24  16009110
         !le16      127
--- a/src/index/joystick.idx.a
+++ b/src/index/joystick.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  16017598
+         !be24  16017601
         !le16     2370
--- a/src/index/miniattract0.idx.a
+++ b/src/index/miniattract0.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15979236
+         !be24  15979239
         !le16     5162
--- a/src/index/miniattract1.idx.a
+++ b/src/index/miniattract1.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15984398
+         !be24  15984401
         !le16     2467
--- a/src/index/prelaunch.idx.a
+++ b/src/index/prelaunch.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15941195
+         !be24  15941198
         !le16     7625
--- a/src/index/search00.idx.a
+++ b/src/index/search00.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15870820
+         !be24  15870823
         !le16     9553
--- a/src/index/search01.idx.a
+++ b/src/index/search01.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15884544
+         !be24  15884547
         !le16    10524
--- a/src/index/search10.idx.a
+++ b/src/index/search10.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15899710
+         !be24  15899713
         !le16    14120
--- a/src/index/search11.idx.a
+++ b/src/index/search11.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15919447
+         !be24  15919450
         !le16    15539
--- a/src/index/sfx.idx.a
+++ b/src/index/sfx.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15965064
+         !be24  15965067
         !le16      358
--- a/src/index/slideshow.idx.a
+++ b/src/index/slideshow.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15973831
+         !be24  15973834
         !le16     5405
--- a/src/index/title.idx.a
+++ b/src/index/title.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15986865
+         !be24  15986868
         !le16     7117
--- a/src/index/xsingle.idx.a
+++ b/src/index/xsingle.idx.a
@ -4,5 +4,5 @@
 ; This file is automatically generated
 ;
         !byte 0
-         !be24  15956384
+         !be24  15956387
         !le16     4400
--- a/src/prelaunch/cider.spider.a
+++ b/src/prelaunch/cider.spider.a
@ -28,7 +28,7 @@
         sta   $1C1E
 +
         lda   #0
-         sta   $306
+         sta   $306       ; uninitialized value in original game
         sta   $10AC
         lda   #1
         sta   $10B1      ; reset vector patch