Video & FrameBase: better split (PR #908)

* Video / FrameBase: move arch specific code to FrameBase.
* Video::Initialize & SetFrameBuffer.
Ensure initialization and SetBuffer can only happen in the right order.
* Video: move virtual functions to FrameBase.
With these changes all the virtual functions are in FrameBase and Video gets closer to be (only) the Apple ][ Video device.
* Move a few more functions from Video to FrameBase (snapshot related)
Now, the inclusion is one way with Video *not* including FrameBase.
* FrameBase::VideoRefreshScreen move Video related code to Video.
And only leave management to FrameBase.

source/FrameBase.cpp

@@ -1,6 +1,9 @@
 #include "StdAfx.h"
 
 #include "FrameBase.h"
+#include "Interface.h"
+#include "Core.h"
+#include "NTSC.h"
 
 FrameBase::FrameBase()
 {
@@ -9,9 +12,135 @@ FrameBase::FrameBase()
 	g_bMultiMon = 0; // OFF = load window position & clamp initial frame to screen, ON = use window position as is
 	g_bFreshReset = false;
 	g_hInstance = (HINSTANCE)0;
+	g_bDisplayPrintScreenFileName = false;
+	g_bShowPrintScreenWarningDialog = true;
 }
 
 FrameBase::~FrameBase()
 {
 
 }
+
+void FrameBase::VideoRefreshScreen(uint32_t uRedrawWholeScreenVideoMode, bool bRedrawWholeScreen)
+{
+	// regenerate video buffer if needed
+	GetVideo().VideoRefreshBuffer(uRedrawWholeScreenVideoMode, bRedrawWholeScreen);
+
+	// actually draw it on screen
+	VideoPresentScreen();
+}
+
+void FrameBase::VideoRedrawScreen(void)
+{
+	// NB. Can't rely on g_uVideoMode being non-zero (ie. so it can double up as a flag) since 'GR,PAGE1,non-mixed' mode == 0x00.
+	VideoRefreshScreen(GetVideo().GetVideoMode(), true);
+}
+
+//===========================================================================
+void FrameBase::VideoRedrawScreenDuringFullSpeed(DWORD dwCyclesThisFrame, bool bInit /*=false*/)
+{
+	if (bInit)
+	{
+		// Just entered full-speed mode
+		dwFullSpeedStartTime = GetTickCount();
+		return;
+	}
+
+	DWORD dwFullSpeedDuration = GetTickCount() - dwFullSpeedStartTime;
+	if (dwFullSpeedDuration <= 16)	// Only update after every realtime ~17ms of *continuous* full-speed
+		return;
+
+	dwFullSpeedStartTime += dwFullSpeedDuration;
+
+	VideoRedrawScreenAfterFullSpeed(dwCyclesThisFrame);
+}
+
+void FrameBase::VideoRedrawScreenAfterFullSpeed(DWORD dwCyclesThisFrame)
+{
+	NTSC_VideoClockResync(dwCyclesThisFrame);
+	VideoRedrawScreen();	// Better (no flicker) than using: NTSC_VideoReinitialize() or VideoReinitialize()
+}
+
+void FrameBase::Video_RedrawAndTakeScreenShot(const char* pScreenshotFilename)
+{
+	_ASSERT(pScreenshotFilename);
+	if (!pScreenshotFilename)
+		return;
+
+	VideoRedrawScreen();
+	Video_SaveScreenShot(Video::SCREENSHOT_560x384, pScreenshotFilename);
+}
+
+void FrameBase::Video_TakeScreenShot(const Video::VideoScreenShot_e ScreenShotType)
+{
+	TCHAR sScreenShotFileName[MAX_PATH];
+
+	// find last screenshot filename so we don't overwrite the existing user ones
+	bool bExists = true;
+	while (bExists)
+	{
+		if (g_nLastScreenShot > nMaxScreenShot) // Holy Crap! User has maxed the number of screenshots!?
+		{
+			TCHAR msg[512];
+			StringCbPrintf(msg, 512, "You have more then %d screenshot filenames!  They will no longer be saved.\n\nEither move some of your screenshots or increase the maximum in video.cpp\n", nMaxScreenShot);
+			MessageBox(GetFrame().g_hFrameWindow, msg, "Warning", MB_OK);
+			g_nLastScreenShot = 0;
+			return;
+		}
+
+		Util_MakeScreenShotFileName(sScreenShotFileName, MAX_PATH);
+		bExists = Util_TestScreenShotFileName(sScreenShotFileName);
+		if (!bExists)
+		{
+			break;
+		}
+		g_nLastScreenShot++;
+	}
+
+	Video_SaveScreenShot(ScreenShotType, sScreenShotFileName);
+	g_nLastScreenShot++;
+}
+
+//===========================================================================
+
+void FrameBase::Video_SaveScreenShot(const Video::VideoScreenShot_e ScreenShotType, const TCHAR* pScreenShotFileName)
+{
+	FILE* pFile = fopen(pScreenShotFileName, "wb");
+	if (pFile)
+	{
+		GetVideo().Video_MakeScreenShot(pFile, ScreenShotType);
+		fclose(pFile);
+	}
+
+	if (g_bDisplayPrintScreenFileName)
+	{
+		MessageBox(GetFrame().g_hFrameWindow, pScreenShotFileName, "Screen Captured", MB_OK);
+	}
+}
+
+void FrameBase::Util_MakeScreenShotFileName(TCHAR* pFinalFileName_, DWORD chars)
+{
+	const std::string sPrefixScreenShotFileName = "AppleWin_ScreenShot";
+	// TODO: g_sScreenshotDir
+	const std::string pPrefixFileName = !g_pLastDiskImageName.empty() ? g_pLastDiskImageName : sPrefixScreenShotFileName;
+	StringCbPrintf(pFinalFileName_, chars, TEXT("%s_%09d.bmp"), pPrefixFileName.c_str(), g_nLastScreenShot);
+}
+
+// Returns TRUE if file exists, else FALSE
+bool FrameBase::Util_TestScreenShotFileName(const TCHAR* pFileName)
+{
+	bool bFileExists = false;
+	FILE* pFile = fopen(pFileName, "rt");
+	if (pFile)
+	{
+		fclose(pFile);
+		bFileExists = true;
+	}
+	return bFileExists;
+}
+
+void FrameBase::Video_ResetScreenshotCounter(const std::string& pImageName)
+{
+	g_nLastScreenShot = 0;
+	g_pLastDiskImageName = pImageName;
+}