Apple-2-Tools/AppleWin
1
0
Fork 0
mirror of https://github.com/AppleWin/AppleWin.git synced 2026-04-20 15:17:50 +00:00
Code Issues Projects Releases Wiki Activity

Debugger: replace sprintf() part 6 - Debugger_Disassembler (PR #1092)

Browse Source 
- Improve FormatCharCopy() to not buffer overflow
- Improve FormatOpcodeBytes() to not buffer overflow
- Improve FormatNopcodeBytes() to not buffer overflow
- Change FormatDisassemblyLine() to return std::string
This commit is contained in:
Kelvin Lee
2022-05-01 23:24:35 +10:00
committed by GitHub
parent b9308b36ea
commit 47ba87a015
3 changed files with 135 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/Debugger/Debug.cpp
+8 -8
View File
@@ -7701,8 +7701,8 @@ void OutputTraceLine ()
DisasmLine_t line;
GetDisassemblyLine( regs.pc, line );
char sDisassembly[ CONSOLE_WIDTH ]; // DrawDisassemblyLine( 0,regs.pc, sDisassembly); // Get Disasm String
FormatDisassemblyLine( line, sDisassembly, CONSOLE_WIDTH );
// DrawDisassemblyLine( 0,regs.pc, sDisassembly); // Get Disasm String
std::string sDisassembly = FormatDisassemblyLine( line );
char sFlags[] = "........";
WORD nRegFlags = regs.ps;
@@ -7758,9 +7758,9 @@ void OutputTraceLine ()
(unsigned)regs.x,
(unsigned)regs.y,
(unsigned)regs.sp,
(char*) sFlags
, sDisassembly
//, sTarget // TODO: Show target?
sFlags
, sDisassembly.c_str()
//, sTarget.c_str() // TODO: Show target?
);
}
else
@@ -7773,9 +7773,9 @@ void OutputTraceLine ()
(unsigned)regs.x,
(unsigned)regs.y,
(unsigned)regs.sp,
(char*) sFlags
, sDisassembly
//, sTarget // TODO: Show target?
sFlags
, sDisassembly.c_str()
//, sTarget.c_str() // TODO: Show target?
);
}
}