Apple-2-Tools/AppleWin
1
0
Fork 0
mirror of https://github.com/AppleWin/AppleWin.git synced 2024-05-28 17:41:37 +00:00
Code Issues Projects Releases Wiki Activity

Simplify the mapping code

Browse Source
This commit is contained in:
tomcw 2024-03-29 21:49:11 +00:00
parent 9bd1b0832d
commit 578271ea8a
1 changed files with 26 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
source/Memory.cpp
View File

@ -1516,9 +1516,6 @@ bool MemIsAddrCodeMemory(const USHORT addr)
static void FreeMemImage(void)
{
#ifdef _MSC_VER
if (memimage == NULL)
return;
if (g_hMemImage)
{
const UINT num64KPages = 2;
@ -1553,44 +1550,41 @@ static LPBYTE AllocMemImage(void)
{
res = false;
const UINT num64KRegions = 2;
const SIZE_T totalVirtualSize = _6502_MEM_LEN * num64KRegions;
g_hMemImage = CreateFileMapping(INVALID_HANDLE_VALUE, 0, PAGE_READWRITE, 0, _6502_MEM_LEN, NULL);
// NB. Returns NULL on failure (not INVALID_HANDLE_VALUE)
if (g_hMemImage != NULL)
UINT retry = 10;
do
{
UINT retry = 10;
do
const SIZE_T totalVirtualSize = _6502_MEM_LEN * num64KRegions;
baseAddr = (LPBYTE)VirtualAlloc(0, totalVirtualSize, MEM_RESERVE, PAGE_NOACCESS);
if (baseAddr)
{
baseAddr = (LPBYTE)VirtualAlloc(0, totalVirtualSize, MEM_RESERVE, PAGE_NOACCESS);
if (baseAddr)
VirtualFree(baseAddr, 0, MEM_RELEASE);
// Create a file mapping object of [64K] size that is backed by the system paging file.
g_hMemImage = CreateFileMapping(INVALID_HANDLE_VALUE, 0, PAGE_READWRITE, 0, _6502_MEM_LEN, NULL);
// NB. Returns NULL on failure (not INVALID_HANDLE_VALUE)
if (g_hMemImage == NULL)
break;
UINT count = 0;
while (count < num64KRegions)
{
VirtualFree(baseAddr, 0, MEM_RELEASE);
UINT count = 0;
while (count < num64KRegions)
{
// MSDN: "To specify a suggested base address for the view, use the MapViewOfFileEx function. However, this practice is not recommended."
// This is why we retry multiple times.
if (!MapViewOfFileEx(g_hMemImage, FILE_MAP_ALL_ACCESS, 0, 0, _6502_MEM_LEN, baseAddr + count * _6502_MEM_LEN))
break;
count++;
}
res = (count == num64KRegions);
if (res)
// MSDN: "To specify a suggested base address for the view, use the MapViewOfFileEx function. However, this practice is not recommended."
// The OS (ie. another process) may've beaten us to this suggested baseAddr. This is why we retry multiple times.
if (!MapViewOfFileEx(g_hMemImage, FILE_MAP_ALL_ACCESS, 0, 0, _6502_MEM_LEN, baseAddr + count * _6502_MEM_LEN))
break;
// Failed this time, so clean-up and retry...
for (UINT i = 0; i < count; i++)
UnmapViewOfFile(baseAddr + i * _6502_MEM_LEN);
count++;
}
}
while (retry--);
if (!res)
res = (count == num64KRegions);
if (res)
break;
// Failed this time, so clean-up and retry...
FreeMemImage();
}
}
while (retry--);
#if 1
if (res) // test