From 94926b4f55fd474b6c8781e25a706f87fed5c5b2 Mon Sep 17 00:00:00 2001
From: tomcw <tomcw@users.noreply.github.com>
Date: Sat, 5 Oct 2019 17:01:35 +0100
Subject: [PATCH] HDD: Fixed SmartPort return address wrong when crossing page
 + some space-saving optimisations (Fixes #319)

---
 firmware/HDD/HDDRVR.BIN | Bin 256 -> 256 bytes
 firmware/HDD/hddrvr.a65 |  33 ++++++++++++---------------------
 resource/Hddrvr.bin     | Bin 256 -> 256 bytes
 3 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/firmware/HDD/HDDRVR.BIN b/firmware/HDD/HDDRVR.BIN
index b579e8438956db8ce64cc74fa27a95f7e4dbb93a..e5c8b10cd4f87153ba8acfc739c3a89f987c990f 100644
GIT binary patch
delta 147
zcmZo*YG6uOsj!k^CG$#~3mg_37$r88PY_+n(EI7Y%7Wg{2iAT#koWPx1P336V;QY(
znanFPTHP}lJZ5+-VBF}|>U81)Hv<${Y&Z%OaXkSf+<=m<t<EQagv*Hwr4tim*p}-g
e9xzxmu}PnG$8n&66ZaU4&xPqk(EsbNa{&OGgE#g7

delta 147
zcmZo*YG6uOsj!k^CG$#~3mg_37$r88Pmo>7(EI7Y%7Wg{2iAT#;Ia1O0g0207Z@!v
zCRq3|9Ls2R%V>4?Sn8I^?6H7xqg$)fi3_X@3>F)X0@<!7fP@=R*tOO91dwn!aiMx*
if(+Ywox}qMt0p$-bMHG2H*exLW5MYRNZ^0{buIvAlRQQM

diff --git a/firmware/HDD/hddrvr.a65 b/firmware/HDD/hddrvr.a65
index fc750587..3cc089f7 100644
--- a/firmware/HDD/hddrvr.a65
+++ b/firmware/HDD/hddrvr.a65
@@ -34,6 +34,7 @@
 ; . GH#370 (Robert Hoem, 27 Oct 2016):
 ;   . Added a check against open-apple during boot to route boot to slot 6
 ;   . This happens after the first two blocks are loaded from the HD.
+; . GH#319: smartport return address wrong when crossing page
 ; TODO:
 ; . Make code relocatable (so HDD controller card can go into any slot)
 ; . Remove support for Entrypoint_C746 (old AppleWin) & Entrypoint_C761 (Apple Oasis)
@@ -108,14 +109,7 @@ Bootstrap
 ; error capturing code.  Applewin is picky
 ; about code assigning data to registers and
 ; memory.  The safest method is via I/O port
- pha
- lda hd_error
- clc
- cmp #1
- bne noerr0
- sec
-noerr0
- pla
+ ror hd_error	; Post: C=0 or 1
  bcc hdboot
 
 ; no image ready, boot diskette image instead
@@ -129,12 +123,14 @@ BootSlot6
 SmartPort
  pla
  sta $46
+ adc #3         ; Pre: C=0, Post: C=0 or 1
+ tay
  pla
- sta $47		; ($47) = &cmd_hdr
+ sta $47        ; ($46) = &cmd_hdr
+ adc #0
  pha
- lda $46
- adc #3			; Pre: C=0, Post: assume C=0
- pha			; (sp).w += 3
+ tya
+ pha            ; (sp).w += 3
 
  ldy #1
  lda ($46),y	; cmd
@@ -143,7 +139,7 @@ SmartPort
  bne SmartPort2
 
 ;======================================
-; 2 unused bytes
+; 8 unused bytes
 
 *= $c746	; org $c746
 
@@ -237,12 +233,7 @@ cmdproc
  bne skipSread
  jsr sread
 skipSread
- lda hd_error
- clc
- cmp #1
- bne noerr2
- sec
-noerr2
+ ror hd_error	; Post: C=0 or 1
  pla
  rts
 
@@ -253,7 +244,7 @@ noerr2
 ; the emulated code increments the buffer by 1 on each read) to (memblock),y
 ; increment memblock+1 and read the second 256 bytes via hd_nextbyte.
 ;
-; if I could figure out how to consistantly get applewin to update it's memory regions all
+; if I could figure out how to consistently get applewin to update it's memory regions all
 ; this code can be moved into the emulation code (although, this is how I'd build the hardware
 ; anyway...)
 
@@ -299,7 +290,7 @@ SmartPort3
  bne cmdproc
 
 ;======================================
-; 12 unused bytes
+; 18 unused bytes
 
 !zone data
 
diff --git a/resource/Hddrvr.bin b/resource/Hddrvr.bin
index b579e8438956db8ce64cc74fa27a95f7e4dbb93a..e5c8b10cd4f87153ba8acfc739c3a89f987c990f 100644
GIT binary patch
delta 147
zcmZo*YG6uOsj!k^CG$#~3mg_37$r88PY_+n(EI7Y%7Wg{2iAT#koWPx1P336V;QY(
znanFPTHP}lJZ5+-VBF}|>U81)Hv<${Y&Z%OaXkSf+<=m<t<EQagv*Hwr4tim*p}-g
e9xzxmu}PnG$8n&66ZaU4&xPqk(EsbNa{&OGgE#g7

delta 147
zcmZo*YG6uOsj!k^CG$#~3mg_37$r88Pmo>7(EI7Y%7Wg{2iAT#;Ia1O0g0207Z@!v
zCRq3|9Ls2R%V>4?Sn8I^?6H7xqg$)fi3_X@3>F)X0@<!7fP@=R*tOO91dwn!aiMx*
if(+Ywox}qMt0p$-bMHG2H*exLW5MYRNZ^0{buIvAlRQQM