Plan to be able to use /usr/local/lib/raspple2 for other things, so
moved the nulib2-version file to a pkginfo subdir.
This gave me an excuse to create something I've wanted for awhile: A
place to stick legacy code that fixes our mistakes that probably doesn't
need to exist forever. I can count the number of people who downloaded
1f8afb6 on a few fingers of one hand most likely, but the change still
got published and I can silently fix my mistake without having to stick
mostly useless code in install_archive_tools someone's gonna look at
three years from now and ask, "does that still need to be there?" No,
no it doesn't. And fixup describes succinctly how long that code needs
to remain there. And the fix is encapsulated into a nice little blob
that's easily removed when the time comes.
Fixes an unfiled bug using the old snapshot where nulib2 fails to
compile on buster/sid systems. Additionally, we now include the version
of nulib2 we've installed in /usr/local/lib/raspple2 so that we can
upgrade this stuff when the time comes to do so.
The Unarchiver for UNIX is available on Debian, Ubuntu, Fedora, and on
macOS under the package name "unar". It's in Arch Linux as well called
"unarchiver". What this means is we really have no need whatsoever to
download the source code and compile it, so we won't.
Also made install_archive_tools ignore args it doesn't understand.
We don't actually download any picopkg files in install_comm_tools
anymore—oysttyer was the only one and we just always pull that from git
and the Readline module from CPAN now. (In buster we'll only need the
CPAN module if Debian doesn't package it.)
Really the only picopkgs which are optional to download are gsport,
linapple, and nulib. And since none of those exist at the moment, you
don't even really have much of an "option" about them either. Yeah, I
know, I'm working on it.
The FIXME about unsafe file handling is resolved. However since nulib2
doesn't build on sid, we need to get that fixed before sid becomes
buster, so a new FIXME is needed.
Now install_archive_tools creates its own temp directories for
installation. Nulib2 doesn't build for me on sid/buster though, we're
going to need a patch I think. We may as well patch it at that point
for building libnufx as a shared lib while we're at it. I really don't
want another project right now. :( This is why we don't get releases
out.
The archiver installation was a pretty simple, isolated chunk of code,
and thus easily pulled into its own script with minimal external
dependencies.
I made few changes, so the new script isn't very tidy unless it's run
from ivan.sh. It should create temp directories for anything it
downloads and clean up after itself when it's finished, but for now it
assumes ivan.sh is doing that. Mostly that's to keep the intellectual
diff small from the code in ivan.sh to the script.
I'll clean this up in an upcoming commit. Feel free to offer PRs that
do this kind of thing to other easily isolated (or not so easily
isolated) chunks. Once ivan.sh is split apart into nice logical pieces,
it will be a lot easier to test and fix individual pieces independent of
the whole. That's something we can't even say for a2server yet.
