Apple-2-Tools/apple2js
1
0
Fork 0
mirror of https://github.com/whscullin/apple2js.git synced 2024-01-12 14:14:38 +00:00
Code Issues Projects Releases Wiki Activity

Improve Disk II test reliability (#195)

Browse Source 
Before, the garbage test had only about a 92% chance of success
because it relied on random numbers not being equal.  This change just
repeats the test 5 times and allows up to 1 failure.  This increases
the chance of the test passing to a hair less that 99.8%.
This commit is contained in:
Ian Flanigan 2023-08-13 00:50:48 +02:00 committed by GitHub
parent 0047b9dbb3
commit 486f554d5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
test/js/cards/disk2.spec.ts
View File

@ -677,28 +677,35 @@ describe('DiskII', () => {
diskII.ioSwitch(0x82); // coil 1 off diskII.ioSwitch(0x82); // coil 1 off
diskII.ioSwitch(0x8e); // read mode diskII.ioSwitch(0x8e); // read mode
// Read 5 nibbles // Try this test 5 times because we could get unlucky.
const nibbles: byte[] = []; let failures = 0;
let read = false; for (let i = 0; i < 5; i++) {
while (nibbles.length < 5) { // Read 5 nibbles
cycles++; const nibbles: byte[] = [];
const nibble = diskII.ioSwitch(0x8c); // read data let read = false;
const qa = nibble & 0x80; while (nibbles.length < 5) {
if (qa && !read) { cycles++;
nibbles.push(nibble); const nibble = diskII.ioSwitch(0x8c); // read data
read = true; const qa = nibble & 0x80;
if (qa && !read) {
nibbles.push(nibble);
read = true;
}
if (!qa && read) {
read = false;
}
} }
if (!qa && read) { // Test that the first doesn't equal any of the others.
read = false; // (Yes, this test could fail with some bad luck.)
let equal = false;
for (let i = 1; i < 5; i++) {
equal ||= nibbles[0] === nibbles[i];
}
if (equal) {
failures++;
} }
} }
// Test that the first doesn't equal any of the others. expect(failures).toBeLessThan(2);
// (Yes, this test could fail with some bad luck.)
let equal = false;
for (let i = 1; i < 5; i++) {
equal ||= nibbles[0] === nibbles[i];
}
expect(equal).not.toBeTruthy();
}); });
it('disk spins at a consistent speed', () => { it('disk spins at a consistent speed', () => {