When GSHK adds files to an archive, it doesn't create threads for
zero-length data and resource forks. NufxLib had a workaround
for this, but it wasn't handling all possible cases. We now
fully handle "Miranda threads" (if you cannot afford a thread,
one will be provided for you).
This broke test-basic, because a callback gets called one extra
time now due to the additional thread. It also broke test-twirl,
which uses "mask dataless" and is sensitive to the order in which
threads appear. (test-twirl actually works just fine, but the
CRC check is too simple-minded, and is arguably incorrect.)
Since this can apparently break things, I'm making this a minor
version bump, to 3.1.0-a1.
I also tweaked the NuLib2 file listing to test for the extended
file storage type, rather than simply scanning for data threads.
Forked files are now listed as such, even when they're missing
the actual resource fork data thread.
Eliminated the two inline functions. Support for function inlining
in plain C is a bit uneven. The CRC calculation is now a macro,
and the thread get-by-index is a plain function.
NufxLib has historically made no effort to distinguish between
the character set used for filenames on the local disk, and for
filenames stored within the archive. Now all Unicode filename
strings use the UNICHAR type and have "UNI" in the name, and all
Mac OS Roman strings have "MOR" in the name. (The naming
convention makes it obvious when you're assigning the wrong thing;
on Linux both formats are char*, so the compiler won't tell you
if you get it wrong.)
The distinction is necessary because filesystems generally support
Unicode these days, but on Windows you need to use a separate
set of wide-character file I/O functions. (On Linux it all works
with "narrow" strings, and the UTF-8 encoding is interpreted by
applications.) The character set used for NuFX archive filenames
is MOR, matching what GS/OS + HFS supported, and we want to be able
to convert back and forth between MOR and a Unicode representation.
This change updates the various character types and string names,
adds conversion functions, and updates NuLib2 for proper execution
on Linux. It does not include the (probably extensive) changes
required for Windows UTF-16 support. Instead, the conversion
functions are no-ops, which should result in NuLib2 for Windows
continuing to behave in the same slightly broken way.
This adds "test-names", which exercises Unicode filenames a bit.
It will not pass on Win32.
Also, tweaked the Linux makefiles to have explicit dependencies,
rather than empty space and an expectation that "makedepend" exists.
Also, minor source code cleanups.
While this probably doesn't affect binary compatibility -- it's
mainly a matter of naming and string interpretation -- there's
enough going on that it should be considered an API revision, so
this updates the version to 3.0.0.
Having the method name up against the left edge used to be common
practice, because you could jump to a method quickly by searching
for "^name". Now we have "ctags" and IDEs.
Fixed filename conversion issues. Specifically:
- Correctly handle '%' when preservation is OFF.
- Accept 4-character extensions in '-ee' without risk of buffer overflow.
- Fixed broken assert when converting long %xx names.
- Store "AUX" as "%00AUX" when preserving names under Win32 (vs. "_AUX").
- Always store files with ':' as path separator.
- Recognize that some Win32 variants (Win2K and later at the least) will
accept both '/' and '\' as pathname separators.
- Correctly convert ".//foo" to "foo" instead of "/foo".
Corrected definition of F_OK under Win32.
auto-config checks for zlib, and enables the features if found. This isn't
ideal, but it'll do.
The "gory debug" output is now available with the "-g" command.
Andy McFadden
cvs