Fixed a bunch of stuff:

* Fixed segfault caused by "touch -c"
	* Fixed segfault caused by "rm -f"
	* Fixed segfault caused by "ln -s -s" and similar abuses.
	* Fixed segfault caused by "cp -a -a" and similar abuses.
	* Implemented "rm -- <foo>"
updated docs accordingly.
 -Erik

Changelog

@@ -50,6 +50,11 @@
 	* Fixed all fatalError() calls lacking a "\n", thanks to Pavel Roskin.
 	* Fixed a segfault in yes when no args were given -- Pavel Roskin.
 	* Simplified freeramdisk and added argument checking -- Pavel Roskin. 
+	* Fixed segfault caused by "touch -c"
+	* Fixed segfault caused by "rm -f"
+	* Fixed segfault caused by "ln -s -s" and similar abuses.
+	* Fixed segfault caused by "cp -a -a" and similar abuses.
+	* Implemented "rm -- <foo>"
 	* "which" rewritten to use stat(). Fixes to improve its compatability
 	    with traditional implementations -- Pavel Roskin.
 	* More doc updates

Makefile

@@ -26,7 +26,7 @@ export VERSION
 # Set the following to `true' to make a debuggable build.
 # Leave this set to `false' for production use.
 # eg: `make DODEBUG=true tests'
-DODEBUG = false
+DODEBUG = true
 
 # If you want a static binary, turn this on.
 DOSTATIC = false

TODO

@@ -26,12 +26,6 @@ Bugs that need fixing before the 0.44 release goes out the door:
 	chmod -R
 	chown -R
 	chgrp -R
-	cp -a -a
-	ln -s -s
-	rm -f
-	rm -f -
-	rm -- -
-	touch -c
   - I believe that swaponoff may also be also broken (check it).
   - It used to be that BusyBox tar would happily overwrite existing files on
       an extraction.  However, as of 0.42, BusyBox tar simply dies as soon as an 

coreutils/ln.c

@@ -59,6 +59,7 @@ extern int ln_main(int argc, char **argv)
 	argv++;
 
 	/* Parse any options */
+	while (--argc >= 0 && *argv && **argv) {
 		while (**argv == '-') {
 			while (*++(*argv))
 				switch (**argv) {
@@ -74,10 +75,14 @@ extern int ln_main(int argc, char **argv)
 					default:
 						usage(ln_usage);
 				}
-		argc--;
+		}
 		argv++;
 	}
 
+	if (argc < 1) {
+		fatalError("ln: missing file argument\n");
+	}
+
 	linkName = argv[argc - 1];
 
 	if (strlen(linkName) > BUFSIZ) {

coreutils/rm.c

@@ -31,7 +31,8 @@
 
 static const char *rm_usage = "rm [OPTION]... FILE...\n"
 #ifndef BB_FEATURE_TRIVIAL_HELP
-	"\nRemove (unlink) the FILE(s).\n\n"
+	"\nRemove (unlink) the FILE(s).  You may use '--' to\n"
+	"indicate that all following arguments are non-options.\n\n"
 	"Options:\n"
 	"\t-f\t\tremove existing destinations, never prompt\n"
 	"\t-r or -R\tremove the contents of directories recursively\n"
@@ -64,15 +65,16 @@ static int dirAction(const char *fileName, struct stat *statbuf, void* junk)
 
 extern int rm_main(int argc, char **argv)
 {
+	int stopIt=FALSE;
 	struct stat statbuf;
 
 	if (argc < 2) {
 		usage(rm_usage);
 	}
-	argc--;
 	argv++;
 
 	/* Parse any options */
+	while (--argc >= 0 && *argv && **argv && stopIt==FALSE) {
 		while (**argv == '-') {
 			while (*++(*argv))
 				switch (**argv) {
@@ -83,10 +85,13 @@ extern int rm_main(int argc, char **argv)
 					case 'f':
 						forceFlag = TRUE;
 						break;
+					case '-':
+						stopIt = TRUE;
+						break;
 					default:
 						usage(rm_usage);
 				}
-		argc--;
+		}
 		argv++;
 	}
 

cp_mv.c

@@ -203,6 +203,7 @@ extern int cp_mv_main(int argc, char **argv)
 	if (dz_i == is_cp) {
 		recursiveFlag = preserveFlag = forceFlag = FALSE;
 		followLinks = TRUE;
+		while (--argc >= 0 && *argv && **argv) {
 			while (**argv == '-') {
 				while (*++(*argv)) {
 					switch (**argv) {
@@ -227,14 +228,18 @@ extern int cp_mv_main(int argc, char **argv)
 						usage(cp_mv_usage[is_cp]);
 					}
 				}
-			argc--;
+			}
 			argv++;
 		}
+		if (argc < 1) {
+			fatalError("cp: missing file argument\n");
+		}
 	} else {					/* (dz_i == is_mv) */
 		recursiveFlag = preserveFlag = TRUE;
 		followLinks = FALSE;
 	}
 	
+
 	if (strlen(argv[argc - 1]) > BUFSIZ) {
 		fprintf(stderr, name_too_long, "cp");
 		goto exit_false;

docs/busybox.pod

@@ -1327,7 +1327,8 @@ Instructs the kernel to reboot the system.
 
 Usage: rm [OPTION]... FILE...
 
-Remove (unlink) the FILE(s).
+Remove (unlink) the FILE(s).  You may use '--' to 
+indicate that all following arguments are non-options.
 
 Options:
 
@@ -1946,4 +1947,4 @@ Enrique Zanardi <ezanardi@ull.es>
 
 =cut
 
-# $Id: busybox.pod,v 1.34 2000/06/05 17:23:06 andersen Exp $
+# $Id: busybox.pod,v 1.35 2000/06/06 16:15:23 andersen Exp $

ln.c

@@ -59,6 +59,7 @@ extern int ln_main(int argc, char **argv)
 	argv++;
 
 	/* Parse any options */
+	while (--argc >= 0 && *argv && **argv) {
 		while (**argv == '-') {
 			while (*++(*argv))
 				switch (**argv) {
@@ -74,10 +75,14 @@ extern int ln_main(int argc, char **argv)
 					default:
 						usage(ln_usage);
 				}
-		argc--;
+		}
 		argv++;
 	}
 
+	if (argc < 1) {
+		fatalError("ln: missing file argument\n");
+	}
+
 	linkName = argv[argc - 1];
 
 	if (strlen(linkName) > BUFSIZ) {

mkfs_minix.c

@@ -188,7 +188,7 @@ static volatile void show_usage()
 	fprintf(stderr,
 			"\t-n [14|30]\tSpecify the maximum length of filenames\n");
 	fprintf(stderr,
-			"\t-i\t\tSpecify the number of inodes for the filesystem\n");
+			"\t-i INODES\tSpecify the number of inodes for the filesystem\n");
 	fprintf(stderr,
 			"\t-l FILENAME\tRead the bad blocks list from FILENAME\n");
 	fprintf(stderr, "\t-v\t\tMake a Minix version 2 filesystem\n\n");

rm.c

@@ -31,7 +31,8 @@
 
 static const char *rm_usage = "rm [OPTION]... FILE...\n"
 #ifndef BB_FEATURE_TRIVIAL_HELP
-	"\nRemove (unlink) the FILE(s).\n\n"
+	"\nRemove (unlink) the FILE(s).  You may use '--' to\n"
+	"indicate that all following arguments are non-options.\n\n"
 	"Options:\n"
 	"\t-f\t\tremove existing destinations, never prompt\n"
 	"\t-r or -R\tremove the contents of directories recursively\n"
@@ -64,15 +65,16 @@ static int dirAction(const char *fileName, struct stat *statbuf, void* junk)
 
 extern int rm_main(int argc, char **argv)
 {
+	int stopIt=FALSE;
 	struct stat statbuf;
 
 	if (argc < 2) {
 		usage(rm_usage);
 	}
-	argc--;
 	argv++;
 
 	/* Parse any options */
+	while (--argc >= 0 && *argv && **argv && stopIt==FALSE) {
 		while (**argv == '-') {
 			while (*++(*argv))
 				switch (**argv) {
@@ -83,10 +85,13 @@ extern int rm_main(int argc, char **argv)
 					case 'f':
 						forceFlag = TRUE;
 						break;
+					case '-':
+						stopIt = TRUE;
+						break;
 					default:
 						usage(rm_usage);
 				}
-		argc--;
+		}
 		argv++;
 	}
 

util-linux/mkfs_minix.c

@@ -188,7 +188,7 @@ static volatile void show_usage()
 	fprintf(stderr,
 			"\t-n [14|30]\tSpecify the maximum length of filenames\n");
 	fprintf(stderr,
-			"\t-i\t\tSpecify the number of inodes for the filesystem\n");
+			"\t-i INODES\tSpecify the number of inodes for the filesystem\n");
 	fprintf(stderr,
 			"\t-l FILENAME\tRead the bad blocks list from FILENAME\n");
 	fprintf(stderr, "\t-v\t\tMake a Minix version 2 filesystem\n\n");