From d077565bb27966c47ea6f0e9de092133954b5807 Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Thu, 13 Aug 2015 15:57:21 +0200 Subject: [PATCH] unit-tests: remove unnecesary field from struct bbunit_listelem In the initial submission struct bbunit_listelem was manipulated by custom list functions implemented in bbunit.c. Since the tests are now added to the list by llist_add_to_end(), which allocates the llist_t objects behind the scenes, there's no need for the *next field. function old new delta unit_main 142 141 -1 bbunit_strrstr_elem 24 16 -8 bbunit_obscure_weak_pass_elem 24 16 -8 bbunit_obscure_strong_pass_elem 24 16 -8 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-25) Total: -25 bytes Signed-off-by: Bartosz Golaszewski Signed-off-by: Denys Vlasenko --- include/libbb.h | 1 - libbb/bbunit.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/libbb.h b/include/libbb.h index 54d01b75a..136d4fd87 100644 --- a/include/libbb.h +++ b/include/libbb.h @@ -1983,7 +1983,6 @@ static ALWAYS_INLINE unsigned char bb_ascii_tolower(unsigned char a) typedef void (*bbunit_testfunc)(void); struct bbunit_listelem { - struct bbunit_listelem* next; const char* name; bbunit_testfunc testfunc; }; diff --git a/libbb/bbunit.c b/libbb/bbunit.c index 4c692d59f..66a7df945 100644 --- a/libbb/bbunit.c +++ b/libbb/bbunit.c @@ -71,7 +71,6 @@ int unit_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) tests_failed++; } tests_run++; - el = el->next; } #if WANT_TIMING