703 Commits

Author	SHA1	Message	Date
Denys Vlasenko	49117b4800	hush: fix a possible bug ... Not sure this was actually a triggerable bug, but the code looked flaky. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-21 14:42:13 +02:00
Denys Vlasenko	85378cded7	hush: code shrink ... function old new delta builtin_wait 347 328 -19 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-11 21:47:11 +02:00
Denys Vlasenko	550bf5b4a4	remove global "jmp_buf die_jmp" from !FEATURE_PREFER_APPLETS builds ... function old new delta xfunc_has_died - 21 +21 sleep_much - 12 +12 sleep10 - 9 +9 die_func - 4 +4 fflush_stdout_and_exit 35 36 +1 builtin_type 121 119 -2 die_sleep 4 - -4 xfunc_die 60 24 -36 hush_main 1128 1011 -117 die_jmp 156 - -156 ------------------------------------------------------------------------------ (add/remove: 4/2 grow/shrink: 1/3 up/down: 47/-315) Total: -268 bytes text data bss dec hex filename 939992 992 17652 958636 ea0ac busybox_old 939880 992 17496 958368 e9fa0 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-09 16:42:57 +02:00
Denys Vlasenko	d60752f8c9	build system: -fno-builtin-printf ... Benefits are: drops reference to out-of-line putchar(), fixes a few cases of failed string merge. function old new delta i2cdump_main 1488 1502 +14 sha256_process_block64 423 433 +10 sendmail_main 1183 1185 +2 list_table 1114 1116 +2 i2cdetect_main 1235 1237 +2 fdisk_main 2852 2854 +2 builtin_type 119 121 +2 unicode_conv_to_printable2 325 324 -1 scan_recursive 380 378 -2 mkfs_minix_main 2687 2684 -3 buffer_fill_and_print 178 169 -9 putchar 152 - -152 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 7/4 up/down: 34/-167) Total: -133 bytes text data bss dec hex filename 937788 932 17676 956396 e97ec busybox_old 937564 932 17676 956172 e970c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 22:42:45 +02:00
Denys Vlasenko	5711a2a4ad	libbb: more compact API for bb_parse_mode() ... function old new delta make_device 2182 2188 +6 parse_command 1440 1443 +3 parse_params 1497 1499 +2 install_main 773 769 -4 mkdir_main 168 160 -8 getoptscmd 641 632 -9 builtin_umask 158 147 -11 bb_parse_mode 431 410 -21 umaskcmd 286 258 -28 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/6 up/down: 11/-81) Total: -70 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 17:55:33 +02:00
Denys Vlasenko	6283f98283	hush: fix umask: umask(022) was setting umask(755) ... Based on the patch by Rich Felker <dalias@libc.org> function old new delta builtin_umask 121 161 +40 umaskcmd 318 279 -39 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 16:56:20 +02:00
Denys Vlasenko	b5be13ccd9	hush: fix a nommu bug where a part of function body is lost if run in a pipe ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-09-04 06:22:10 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code ... This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Maninder Singh	97c6491b4e	typo fixes ... Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-05-25 13:46:36 +02:00
Denys Vlasenko	8dff01d06a	libbb: introduce and use is_prefixed_with() ... function old new delta is_prefixed_with - 18 +18 complete_username 78 77 -1 man_main 737 735 -2 fsck_device 429 427 -2 unpack_ar_archive 80 76 -4 strip_unsafe_prefix 105 101 -4 singlemount 1054 1050 -4 rtc_adjtime_is_utc 90 86 -4 resolve_mount_spec 88 84 -4 parse_one_line 1029 1025 -4 parse_conf 1460 1456 -4 may_wakeup 83 79 -4 loadkmap_main 219 215 -4 get_irqs_from_stat 103 99 -4 get_header_cpio 913 909 -4 findfs_main 79 75 -4 fbsplash_main 1230 1226 -4 load_crontab 776 771 -5 expand_vars_to_list 1151 1146 -5 date_main 881 876 -5 skip_dev_pfx 30 24 -6 make_device 2199 2193 -6 complete_cmd_dir_file 773 767 -6 run_applet_and_exit 715 708 -7 uudecode_main 321 313 -8 pwdx_main 197 189 -8 execute 568 560 -8 i2cdetect_main 1186 1176 -10 procps_scan 1242 1230 -12 procps_read_smaps 1017 1005 -12 process_module 746 734 -12 patch_main 1903 1891 -12 nfsmount 3572 3560 -12 stack_machine 126 112 -14 process_timer_stats 449 435 -14 match_fstype 111 97 -14 do_ipaddr 1344 1330 -14 open_list_and_close 359 343 -16 get_header_tar 1795 1779 -16 prepend_new_eth_table 340 323 -17 fsck_main 1811 1794 -17 find_iface_state 56 38 -18 dnsd_main 1321 1303 -18 base_device 179 158 -21 find_keyword 104 82 -22 handle_incoming_and_exit 2785 2762 -23 parse_and_put_prompt 774 746 -28 modinfo 347 317 -30 find_action 204 171 -33 update_passwd 1470 1436 -34 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/49 up/down: 18/-540) Total: -522 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-03-12 17:48:34 +01:00
Denys Vlasenko	841f8331d7	ash,hush: run reinit_unicode() only if makes sense ... With static Unicode support, no need to check $LANG et al. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-08-13 10:09:49 +02:00
Denys Vlasenko	c538d5bcc3	hush: make ${#var} unicode-aware ... This mimics bash Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-08-13 09:57:44 +02:00
Denys Vlasenko	3fa97af7cc	ash,hush: set $HOSTNAME is bash compat. Closes 7028 ... function old new delta hush_main 1056 1128 +72 ash_main 1442 1487 +45 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-15 11:43:29 +02:00
Denys Vlasenko	2bba591991	hush: make "true" built-in ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-03-14 12:43:57 +01:00
Denys Vlasenko	8bd810bd27	hush: typo fixes in comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-11-28 01:50:01 +01:00
Denys Vlasenko	e95738f635	typo fix in comment ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-08 03:13:08 +02:00
Denys Vlasenko	2301d127a2	unicode: check $LC_CTYPE too to detect Unicode mode ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-05 22:00:57 +02:00
Denys Vlasenko	3e7ecb179b	unicode: check $LC_ALL to detect Unicode mode, not only $LANG ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-07-02 17:30:23 +02:00
Denys Vlasenko	ff463a885d	hush: fix build failure if FEATURE_EDITING=y && !HUSH_INTERACTIVE ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-05-12 02:45:23 +02:00
Flemming Madsen	d96ffda62e	ash,hush: history builtin ... function old new delta show_history - 39 +39 builtin_history - 16 +16 historycmd - 13 +13 bltins1 312 324 +12 builtintab 336 344 +8 popstring 134 140 +6 hush_main 1048 1046 -2 ash_main 1398 1396 -2 size_from_HISTFILESIZE 44 40 -4 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 3/3 up/down: 94/-8) Total: 86 bytes Signed-off-by: Flemming Madsen <busybox@themadsens.dk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-04-07 18:47:24 +02:00
Denys Vlasenko	3beab83e4f	hush: fix for "while false && true; do echo BUG; break; done". closes 6170 ... function old new delta run_list 959 941 -18 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-04-07 18:16:58 +02:00
Denys Vlasenko	88b532d59a	hush: source builtin should override $N only if it has args ... function old new delta builtin_source 174 184 +10 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-17 14:11:04 +01:00
Denys Vlasenko	6830ade6aa	whitespace fixes. no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-15 13:58:01 +01:00
Denys Vlasenko	60cb48ca50	whitespace cleanup. no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-14 15:57:44 +01:00
Denys Vlasenko	9d75370238	hush: remove sighandler_t definition hack, platform.h has it too ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-04-26 10:59:01 +02:00
Denys Vlasenko	8cab66730a	fix build breakage found by randconfig ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-04-20 14:48:00 +02:00
Denys Vlasenko	0d6bbb0497	hush: remove unused member struct command::is_stopped ... function old new delta builtin_umask 133 132 -1 checkjobs 551 544 -7 builtin_fg_bg 291 267 -24 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-03-27 14:32:48 +02:00
Denys Vlasenko	e45af7ad17	lineedit: remove SAVE_HISTORY bit, ->hist_file can be used as indicator ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 16:15:24 +02:00
Denys Vlasenko	bede215cf1	lineedit: add support for history saving on exit ... Based on the patch by Dennis Groenen <tj.groenen@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 16:12:33 +02:00
Denys Vlasenko	4840ae8a06	lineedit: fix atomic replace of history file; hush: fix $HISTFILE handling ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-04 15:28:03 +02:00
Denys Vlasenko	b347df9131	randomconfig fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-09 22:49:15 +02:00
Denys Vlasenko	6e42b89b8d	hush: fix remaining known two bugs with IFS expansion. Closes 4027. ... function old new delta expand_vars_to_list 1054 1140 +86 parse_stream 2425 2479 +54 expand_on_ifs 258 310 +52 builtin_umask 133 132 -1 done_word 820 779 -41 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 192/-42) Total: 150 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-01 18:16:43 +02:00
Denys Vlasenko	4fb53fb08c	hush: partially fix wrong expansion on $IFS (bug 4027). ... In the added testcase, before patch we failed 8 out of 9 tests, now we fail only 2 (4th and 5th). function old new delta expand_on_ifs 225 258 +33 expand_vars_to_list 1038 1054 +16 o_save_ptr_helper 115 119 +4 builtin_umask 132 133 +1 o_addQstr 165 161 -4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/1 up/down: 54/-4) Total: 50 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-08-01 14:06:20 +02:00
Denys Vlasenko	56a3b82e96	hush: better comment. No code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-01 12:47:07 +02:00
Denys Vlasenko	00ae989ee5	hush: fix a corner case of empty "do \n done" structure ... The structure is: while cmd; do done bash doesn't accept it at all. We were accepting it but execution was buggy. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-31 17:35:45 +02:00
Denys Vlasenko	29f9b7268a	hush: fix misparsing of "... do eval a= ...". Closes 3721 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-14 11:27:36 +02:00
Denys Vlasenko	60a9414cad	fix "variable 'foo' set but not used" warnings ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-13 20:57:01 +02:00
Denys Vlasenko	0806e401d6	hush: install signal handlers with filled sigmask ... function old new delta install_sighandler - 39 +39 hush_main 1001 1031 +30 builtin_trap 386 392 +6 install_sighandlers 121 123 +2 switch_off_special_sigs 87 86 -1 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/1 up/down: 77/-1) Total: 76 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 23:06:20 +02:00
Denys Vlasenko	75e77deab1	hush: fixes and small shrink for HUSH_JOB!=y ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 13:12:47 +02:00
Denys Vlasenko	ebc1ee2e2a	hush: remove one sigprocmask from exit path ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 10:59:18 +02:00
Denys Vlasenko	0c40a731e3	hush: add forgotten {} in multi-statement if. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 09:50:12 +02:00
Denys Vlasenko	f58f705c58	hush: fix login shell's signal handling; add -l option so that it's easier to test ... function old new delta hush_main 958 1001 +43 install_special_sighandlers 47 52 +5 packed_usage 28752 28741 -11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 48/-11) Total: 37 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-12 02:10:33 +02:00
Denys Vlasenko	9d6cbafe72	hush: replace signal handling machinery ... With new version of signal handling, read builtin should be less buggy wrt signals. function old new delta install_sighandlers - 121 +121 switch_off_special_sigs - 84 +84 pick_sighandler - 58 +58 install_special_sighandlers - 47 +47 builtin_wait 284 319 +35 record_pending_signo - 21 +21 execvp_or_die 43 48 +5 file_get 290 288 -2 run_list 1004 998 -6 static.zero_timespec 8 - -8 sigprocmask_set 14 - -14 sigwaitinfo 23 - -23 record_signal 23 - -23 __GI_sigwaitinfo 23 - -23 sigtimedwait 25 - -25 builtin_trap 417 392 -25 __GI_sigtimedwait 25 - -25 hush_main 1003 965 -38 check_and_run_traps 263 217 -46 __rt_sigtimedwait 52 - -52 reset_traps_to_defaults 213 126 -87 init_sigmasks 198 - -198 builtin_read 536 197 -339 ------------------------------------------------------------------------------ (add/remove: 5/10 grow/shrink: 2/7 up/down: 371/-934) Total: -563 bytes text data bss dec hex filename 903075 936 17736 921747 e1093 busybox_old 902547 936 17736 921219 e0e83 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-11 23:56:11 +02:00
Denys Vlasenko	10c0131a8a	hush: use SA_RESTARTed signal handlers across read. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-11 11:49:21 +02:00
Denys Vlasenko	54e9e1217c	hush: code shrink ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-09 00:52:15 +02:00
Denys Vlasenko	80542bad2f	hush: make read builtin interruptible. ... function old new delta builtin_read 185 471 +286 check_and_run_traps 200 262 +62 nonblock_immune_read 73 119 +46 sigismember - 44 +44 record_signal - 21 +21 sigisemptyset - 16 +16 ... ------------------------------------------------------------------------------ (add/remove: 5/0 grow/shrink: 7/5 up/down: 483/-46) Total: 437 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-08 21:23:43 +02:00
Denys Vlasenko	b8709032a3	hush: fix incorrect PS2 dispaly and trap handling while reading command ... The fix affects only !ENABLE_FEATURE_EDITING configuration Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-08 21:20:01 +02:00
Denys Vlasenko	2c4de5b045	ash,hush: optional support for $HISTFILESIZE. ... Based on patch from Alexey Fomenko (ext-alexey.fomenko AT nokia.com) function old new delta size_from_HISTFILESIZE - 44 +44 hush_main 998 1025 +27 ash_main 1348 1374 +26 read_line_input 3361 3372 +11 new_line_input_t 17 24 +7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-31 13:16:52 +02:00
Denys Vlasenko	a439fa93f6	hush: remove outdated comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-30 19:11:46 +02:00
Denys Vlasenko	cecbc98611	hush: fix source1.tests ... function old new delta parse_and_run_stream 95 139 +44 static_get 22 25 +3 file_get 260 263 +3 builtin_umask 133 132 -1 parse_stream 2442 2425 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 50/-18) Total: 32 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-03-30 18:54:52 +02:00