Change hardcoded fds to STDIN_FILENO and STDERR_FILENO.

This commit is contained in:
Stephen Heumann 2015-06-10 23:23:50 -05:00
parent 98b485d83b
commit 03a535e170

View File

@ -874,7 +874,7 @@ getptyslave(void)
set_termbuf(); set_termbuf();
if (login_tty(t) == -1) if (login_tty(t) == -1)
fatalperror(net, "login_tty"); fatalperror(net, "login_tty");
if (net > 2) if (net > STDERR_FILENO)
(void) close(net); (void) close(net);
#ifdef AUTHENTICATION #ifdef AUTHENTICATION
#if defined(NO_LOGIN_F) && defined(LOGIN_R) #if defined(NO_LOGIN_F) && defined(LOGIN_R)
@ -883,7 +883,7 @@ getptyslave(void)
* protocol for /bin/login, if the authentication works. * protocol for /bin/login, if the authentication works.
*/ */
#else #else
if (pty > 2) { if (pty > STDERR_FILENO) {
(void) close(pty); (void) close(pty);
pty = -1; pty = -1;
} }
@ -1084,7 +1084,7 @@ start_login(char *host undef1, int autologin undef1, char *name undef1)
* local-user\0remote-user\0term/speed\0 * local-user\0remote-user\0term/speed\0
*/ */
if (pty > 2) { if (pty > STDERR_FILENO) {
char *cp; char *cp;
char speed[128]; char speed[128];
int isecho, israw, xpty, len; int isecho, israw, xpty, len;
@ -1107,7 +1107,7 @@ start_login(char *host undef1, int autologin undef1, char *name undef1)
argv = addarg(argv, LOGIN_HOST); argv = addarg(argv, LOGIN_HOST);
xpty = pty; xpty = pty;
pty = 0; pty = STDIN_FILENO;
init_termbuf(); init_termbuf();
isecho = tty_isecho(); isecho = tty_isecho();
israw = tty_israw(); israw = tty_israw();
@ -1161,7 +1161,7 @@ start_login(char *host undef1, int autologin undef1, char *name undef1)
} }
#ifdef AUTHENTICATION #ifdef AUTHENTICATION
#if defined(NO_LOGIN_F) && defined(LOGIN_R) #if defined(NO_LOGIN_F) && defined(LOGIN_R)
if (pty > 2) if (pty > STDERR_FILENO)
close(pty); close(pty);
#endif #endif
#endif /* AUTHENTICATION */ #endif /* AUTHENTICATION */