From 6b099757e86e490921e3bbca843ddbf1ea87c412 Mon Sep 17 00:00:00 2001 From: kevlo Date: Fri, 28 Sep 2012 07:51:30 +0000 Subject: [PATCH] Make sure that each va_start has one and only one matching va_end, especially in error cases. git-svn-id: http://svn0.us-east.freebsd.org/base/head/contrib/telnet@241021 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- telnetd/state.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/telnetd/state.c b/telnetd/state.c index 300421f..9cad0c5 100644 --- a/telnetd/state.c +++ b/telnetd/state.c @@ -1600,8 +1600,10 @@ output_data(const char *format, ...) char *buf; va_start(args, format); - if ((len = vasprintf(&buf, format, args)) == -1) + if ((len = vasprintf(&buf, format, args)) == -1) { + va_end(args); return -1; + } output_datalen(buf, len); va_end(args); free(buf);