SonarCloud coverage setup, fixed numerous SonarCloud issues (#840)

* SonarCloud coverage setup, fixed numerous SonarCloud issues

* Code cleanup

.github/workflows/run_tests.yml

@@ -3,68 +3,33 @@ name: Run automated unit tests
 on: [push, pull_request]
 
 jobs:
-  functional_test:
-    runs-on: ubuntu-22.04
-    steps:
-    - uses: actions/checkout@v3
-    
-    - name: Install libraries
-      run: sudo apt-get install libspdlog-dev libpcap-dev libevdev2 libev-dev protobuf-compiler libgtest-dev libgmock-dev
-    
-    - name: Run tests
-      run: make -C src/raspberrypi -j6 test
-      
-    - name: Save Log
-      run: src/raspberrypi/bin/fullspec/rascsi_test | tee test_log.txt
-      
-    - name: upload artifacts
-      uses: actions/upload-artifact@v2
-      with:
-        name: test log
-        path: test_log.txt
-  
-  code_coverage_test:
-    runs-on: ubuntu-22.04
-    steps:
-    - uses: actions/checkout@v3
-        
-    - name: Install libraries
-      run: sudo apt-get install libspdlog-dev libpcap-dev libevdev2 libev-dev protobuf-compiler libgtest-dev libgmock-dev lcov
-    
-    - name: Gerenate coverage
-      run: make -C src/raspberrypi -j6 coverage
-     
-    - name: tar coverage data
-      run: tar -czvf coverage.tar.gz ./coverage
-      working-directory: ./src/raspberrypi
-      
-    - name: upload artifacts
-      uses: actions/upload-artifact@v2
-      with:
-        name: Coverage data
-        path: ./src/raspberrypi/coverage.tar.gz
-
-
-  SonarCloud_Analysis:
+  Tests_and_SonarCloud_Analysis:
     runs-on: ubuntu-22.04
     env:
+      MAKEFLAGS: -j2 # Number of available processors
+      SOURCES: src/raspberrypi
       SONAR_SCANNER_VERSION: 4.7.0.2747
       SONAR_SERVER_URL: "https://sonarcloud.io"
       BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed
     steps:
       - uses: actions/checkout@v2
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: Install cross compile toolchain
-        run: sudo apt-get install gcc-arm-linux-gnueabihf g++-arm-linux-gnueabihf binutils-arm-linux-gnueabihf libspdlog-dev libpcap-dev protobuf-compiler
-
+          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
       - name: Install dependencies
-        run: sudo apt-get install libspdlog-dev libpcap-dev protobuf-compiler libprotobuf-dev libprotobuf-c-dev libev-dev libevdev2 libgmock-dev
+        run: sudo apt-get install libspdlog-dev libpcap-dev libevdev2 libev-dev protobuf-compiler libgtest-dev libgmock-dev
 
-      - name: Set up JDK 11
+      - name: Run unit tests and save log
+        run: $SOURCES/bin/fullspec/rascsi_test | tee test_log.txt
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v2
+        with:
+          name: test log
+          path: test_log.txt
+
+      - name: Set up JDK 17
         uses: actions/setup-java@v1
         with:
-          java-version: 11
+          java-version: 17
       - name: Download and set up sonar-scanner
         env:
           SONAR_SCANNER_DOWNLOAD_URL: https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${{ env.SONAR_SCANNER_VERSION }}-linux.zip
@@ -82,11 +47,14 @@ jobs:
           echo "$HOME/.sonar/build-wrapper-linux-x86" >> $GITHUB_PATH
       - name: Run build-wrapper
         run: |
-          build-wrapper-linux-x86-64 --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} make -C src/raspberrypi -j6 all
+          build-wrapper-linux-x86-64 --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} make -C $SOURCES coverage
+
+      - name: Run gcov
+        run: (cd $SOURCES ; gcov --preserve-paths $(find -name '*.gcno'))
       - name: Run sonar-scanner
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          sonar-scanner --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" --define sonar.projectKey=akuker_RASCSI --define sonar.organization=rascsi
+          cd $SOURCES | sonar-scanner --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" --define sonar.projectKey=akuker_RASCSI --define sonar.organization=rascsi --define sonar.cfamily.gcov.reportsPath=. --define sonar.cfamily.cache.enabled=false --define sonar.coverage.exclusions="tests/*" --define sonar.python.version=3