Address SonarQube issues

cpp/devices/disk_cache.cpp

@@ -30,7 +30,7 @@ DiskCache::DiskCache(const string& path, int size, uint32_t blocks, off_t imgoff
 bool DiskCache::Save() const
 {
 	// Save valid tracks
-	return none_of(cache.begin(), cache.end(), [this](const cache_t& c)
+	return ranges::none_of(cache.begin(), cache.end(), [this](const cache_t& c)
 			{ return c.disktrk != nullptr && !c.disktrk->Save(sec_path); });
 }
 

cpp/piscsi/piscsi_core.cpp

@@ -596,7 +596,7 @@ void Piscsi::ShutDown(AbstractController::piscsi_shutdown_mode shutdown_mode)
 {
 	CleanUp();
 
-	switch(shutdown_mode) { //NOSONAR using enum is not supported by the bullseye compiler
+	switch(shutdown_mode) {
 	case AbstractController::piscsi_shutdown_mode::STOP_PISCSI:
 		spdlog::info("PiSCSI shutdown requested");
 		break;

cpp/test/phase_handler_test.cpp

@@ -96,7 +96,7 @@ TEST(PhaseHandlerTest, Phases)
 }
 
 TEST(PhaseHandlerTest, ProcessPhase)
-{ //NOSONAR using enum is not supported by the bullseye clang++ compiler
+{
 	MockPhaseHandler handler;
 
 	handler.SetPhase(phase_t::selection);

cpp/test/primary_device_test.cpp

@@ -90,7 +90,7 @@ TEST(PrimaryDeviceTest, CheckReservation)
 }
 
 TEST(PrimaryDeviceTest, ReserveReleaseUnit)
-{ //NOSONAR using enum is not supported by the bullseye clang++ compiler
+{
 	auto [controller, device] = CreatePrimaryDevice();
 
 	device->Dispatch(scsi_command::eCmdReserve6);