Summary ov most important changes triggered by the SASI code removal:
- Removed the SASI controller code
- New controller management. There is a new controller base class AbstractController and a class ControllerManager managing the controller lifecycle. The lifecycle management was removed from rasci.cpp and is covered by unit tests.
- New device management. The DeviceFactory manages the device lifecycle instead of rascsi.cpp. The new code is covered by unit tests.
- The lifecycle managment uses C++ collections with variable size instead of arrays with hard-coded sizes.
- The ScsiController method contains most of what was previously contained in scsidev_ctrl.cpp plus the code from sasidev_ctrl.cpp that was relevant for SCSI.
- scsi_command_util contains helper methods used for identical SCSI command implementations of more than one device
- Devices know their controllers, so that the controller instance does not need to be passed to each SCSI command. This change helps to decouple the devices from the controller. The phase_handler interface is also part of this decoupling.
- Use scsi_command_exception for propagating SCSI command execution errors, This resolves issues with the previous error handling, which was based on return values and often on magic numbers.
- Removed legacy SCSI error codes, all errors are now encoded by sense_key::, asc:: and status::.
- Fixed various warnings reported with -Wextra, -Weffc++ and -Wpedantic.
- Use constructor member initialization lists (recommended for ISO C++)
- Consistently use new/delete instead of malloc/free (recommended for ISO C++), resulting in better type safety and error handling
- Replaced variable sized arrays on the stack (violates ISO C++ and can cause a stack overflow)
- Replaced NULL by nullptr (recommended for C++), resulting in better type safety
- Use more const member functions in order to avoid side effects
- The format device page can now also be changed for hard disk drives (Fujitsu M2624S supports this, for instance), not just for MOs.
- Better encapsulation, updated access specifiers in many places
- Removed unused methods and method arguments
- Fixed a number of TODOs
- Added/updated unit tests for a lot of non-legacy classes
- Makefile support for creating HTML coverage reports with lcov/genhtml
* Initial dummy test
* Makefile update
* Make protected method visible
* Test update
* Test update
* Updated mode page device
* Only build tests with explicit test target
* make test builds and executes tests
* Replaced constant
* Added TODO
* Merged develop
* Added unit test
* Comment update
* Unit test update
* Added tests
* Added tests
* Test cleanup
* Updated error handling
* Reverted MODE SENSE change
* Reverted last change
* Use GoogleMock
* Comment update
* Signature update
* Cleanup
* Cleanup
* Further cleanup
* Removed obsolete comment
* Updated error handling
* Cleanup
* Added TODO
* Added test
* Added test
* Renaming
* Added test
* Cleanup
* Header update
* Added two tests
* Renaming
* Fixed test argument order
* Namespaces are needed in order to avoid name clashes
* Added test
* Added tests
* Added tests
* Added tests
* Added tests
* Updated host services test
* Merge with develop
* Moved code
* Renaming
* Added tests
* Added tests
* Initial device tests
* Test cleanup
* Added test
* Removed cast
* RASCSI_TEST target has to depend on SRC_PROTOBUF
* Allow custom drive image sizes in the bespoke UI. Addresses Issue#748
* Clarify what the Pi repo mirror setup is good for.
* Use the number input type for rudimentary input validation.
* Append byte unit.
* More granular input validation using html5 attributes. Max allowed input is 256GiB in bytes.
* Correct use of html5 number input elements.
* Use the pip3 alias to work on older systems, such as Buster
* Put Reloaded into the main menu
* Make sure working dirs are created earlier in the process. Issue#803
* Update web README to point to the right dir and url
* Notify that an ssl cert is being created.
* Document the de-facto release number strategy of this project.
Co-authored-by: RaSCSI User <user@rascsi.com>
