* Resolved issues 772, 827, 909
* Added numerous unit tests
* Code cleanup
* Improved type safety by using PbDeviceType instead of string
* Do not flush cache on failed STOP UNIT
* Error message and error handling updates
* Removed duplicate code
* Use map for mapping shift counts
* Reject read/write access if the drive has 0 sectors
* Updated logging configuration for tests
* Merged FileSupport into Disk
* Improved code granularity
* Made classes previously directly writing to cout testable
* Added numerous unit tests
* Fixed minor issues uncovered by unit tests
* Fixed SonarCloud issues
* Replaced remaining proprietary data types (WORD/DWORD) except for files in hal/
* Removed static/global variable
* No need for ControllerManager as a singleton
* Updated factory handling
* Replaced loops
* Added const
* Added translations, fixed TODO, simplified operation creation
* Fixed SonarCloud warnings
* Replaced void * by BYTE *
* Added explicit mode_page_datetime struct
* Unit test updates
* Use enum classes
* Upddated file size check
* Use C++ output formatting
* Removed unused code
* Use array for garbage buffer
* Fixed data returned by READ CAPACITY(10)
* For mode pages: Replaced BYTE by std::byte
* Use std::byte for INQUIRY
* Use std::byte for REQUEST SENSE
* Replaced C array by vector
* Replaced C style array
* Replaced BYTE by std::byte
* Replaced DWORD
* Use more byte arreys
* Updated CTapDriver initialization/deletion
* Made status uint32_t instead of DWORD
* Replaced command byte array by vector
* Updated error handling
* Removed obsolete casts
* Improved locality of code
* rw_command has become obsolete
* Dynamically allocate command byte buffer
* Simplified receiving commands
* Use references
* Type safety update, dispatcher update
* Removed macros, replaced BOOL/FALSE/TRUE
Summary ov most important changes triggered by the SASI code removal:
- Removed the SASI controller code
- New controller management. There is a new controller base class AbstractController and a class ControllerManager managing the controller lifecycle. The lifecycle management was removed from rasci.cpp and is covered by unit tests.
- New device management. The DeviceFactory manages the device lifecycle instead of rascsi.cpp. The new code is covered by unit tests.
- The lifecycle managment uses C++ collections with variable size instead of arrays with hard-coded sizes.
- The ScsiController method contains most of what was previously contained in scsidev_ctrl.cpp plus the code from sasidev_ctrl.cpp that was relevant for SCSI.
- scsi_command_util contains helper methods used for identical SCSI command implementations of more than one device
- Devices know their controllers, so that the controller instance does not need to be passed to each SCSI command. This change helps to decouple the devices from the controller. The phase_handler interface is also part of this decoupling.
- Use scsi_command_exception for propagating SCSI command execution errors, This resolves issues with the previous error handling, which was based on return values and often on magic numbers.
- Removed legacy SCSI error codes, all errors are now encoded by sense_key::, asc:: and status::.
- Fixed various warnings reported with -Wextra, -Weffc++ and -Wpedantic.
- Use constructor member initialization lists (recommended for ISO C++)
- Consistently use new/delete instead of malloc/free (recommended for ISO C++), resulting in better type safety and error handling
- Replaced variable sized arrays on the stack (violates ISO C++ and can cause a stack overflow)
- Replaced NULL by nullptr (recommended for C++), resulting in better type safety
- Use more const member functions in order to avoid side effects
- The format device page can now also be changed for hard disk drives (Fujitsu M2624S supports this, for instance), not just for MOs.
- Better encapsulation, updated access specifiers in many places
- Removed unused methods and method arguments
- Fixed a number of TODOs
- Added/updated unit tests for a lot of non-legacy classes
- Makefile support for creating HTML coverage reports with lcov/genhtml
