From 309256521c8cf5600d1ab25d892e91c37206f55c Mon Sep 17 00:00:00 2001 From: joshua stein Date: Tue, 22 Mar 2022 11:46:57 -0700 Subject: [PATCH] Clarify which files things are in --- Rules-for-adding-new-device-types.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Rules-for-adding-new-device-types.md b/Rules-for-adding-new-device-types.md index 23d0fd9..4b0680c 100644 --- a/Rules-for-adding-new-device-types.md +++ b/Rules-for-adding-new-device-types.md @@ -2,8 +2,8 @@ Before adding a new device type check that none of the existing types is appropr Steps for adding a new device type: -1. Add the device type to the PbDeviceType enum of the protobuf definition. -2. Add code for creating the device type to the DeviceFactory class. The device instance and all devices-specific properties have to be created by this class. +1. Add the device type to the PbDeviceType enum of the protobuf definition in `rascsi_interface.proto`. +2. Add code for creating the device type to the DeviceFactory class in `devices/device_factory.cpp`. The device instance and all devices-specific properties have to be created by this class. 3. Add the device type specific implementation in new .cpp/.h files. 4. Ensure to initialize the device type with its device type properties. 5. Verify that _rasctl -s_ reports the correct device type properties.