From 36eab8918473ab575ed11c87cee33954a52e6a1d Mon Sep 17 00:00:00 2001 From: Simon Goldschmidt Date: Wed, 4 Jun 2014 21:17:25 +0200 Subject: [PATCH] SMTP: Add comment about 'err' checking in connect callback --- apps/smtp/smtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/smtp/smtp.c b/apps/smtp/smtp.c index 90b2728..1a979bd 100644 --- a/apps/smtp/smtp.c +++ b/apps/smtp/smtp.c @@ -751,6 +751,7 @@ smtp_tcp_connected(void *arg, struct tcp_pcb *pcb, err_t err) if (err == ERR_OK) { LWIP_DEBUGF(SMTP_DEBUG_STATE, ("smtp_connected: Waiting for 220\n")); } else { + /* shouldn't happen, but we still check 'err', only to be sure */ LWIP_DEBUGF(SMTP_DEBUG_WARN, ("smtp_connected: %d\n", (int)err)); smtp_close(arg, pcb, SMTP_RESULT_ERR_CONNECT, 0, err); }