Macintosh-SW
/
tenfourfox
mirror of https://github.com/classilla/tenfourfox.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

#651: M1786188 M1791029

This commit is contained in:
Cameron Kaiser 2023-04-16 15:32:14 -07:00
parent 9197c15057
commit 28b4c08821
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
xpcom/io/nsLocalFileUnix.cpp
View File

@ -1572,13 +1572,22 @@ nsLocalFile::IsExecutable(bool* aResult)
// Search for any of the set of executable extensions.
static const char* const executableExts[] = {
#ifdef MOZ_WIDGET_COCOA
"afploc", // Can point to other files.
#endif
"air", // Adobe AIR installer
#ifdef MOZ_WIDGET_COCOA
"inetloc", // https://ssd-disclosure.com/ssd-advisory-macos-finder-rce/
"atloc", // Can point to other files.
"fileloc", // File location files can be used to point to other files.
"webloc", // same URL
"ftploc", // Can point to other files.
"inetloc", // https://ssd-disclosure.com/ssd-advisory-macos-finder-rce/
// Shouldn't be able to do the same, but can, due to
// macOS vulnerabilities.
#endif
"jar" // java application bundle
#ifdef MOZ_WIDGET_COCOA
,"webloc" // same URL
#endif
};
nsDependentSubstring ext = Substring(path, dotIdx + 1);
for (size_t i = 0; i < ArrayLength(executableExts); i++) {
@ -1781,11 +1790,14 @@ nsLocalFile::GetNativeTarget(nsACString& aResult)
return NS_ERROR_OUT_OF_MEMORY;
}
if (readlink(mPath.get(), target, (size_t)size) < 0) {
ssize_t written = readlink(mPath.get(), target, (size_t)size);
if (written < 0) {
free(target);
return NSRESULT_FOR_ERRNO();
}
target[size] = '\0';
// Target might have changed since the lstat call, or lstat might lie, see bug
// 1791029.
target[written] = '\0';
nsresult rv = NS_OK;
nsCOMPtr<nsIFile> self(this);