From 438ff2c96fc946ebec4f1e9dc4d5c80c74e3a560 Mon Sep 17 00:00:00 2001 From: Cameron Kaiser Date: Sat, 17 Jun 2017 20:45:26 -0700 Subject: [PATCH] #403 (#375): last minute perf wins from M1357146 M1363956 --- browser/components/nsBrowserGlue.js | 33 ----------------------------- js/src/proxy/Wrapper.cpp | 2 +- 2 files changed, 1 insertion(+), 34 deletions(-) diff --git a/browser/components/nsBrowserGlue.js b/browser/components/nsBrowserGlue.js index 6d39b4280..e4c64a348 100644 --- a/browser/components/nsBrowserGlue.js +++ b/browser/components/nsBrowserGlue.js @@ -2913,8 +2913,6 @@ ContentPermissionPrompt.prototype = { var DefaultBrowserCheck = { get OPTIONPOPUP() { return "defaultBrowserNotificationPopup" }, - _setAsDefaultTimer: null, - _setAsDefaultButtonClickStartTime: 0, closePrompt: function(aNode) { if (this._notification) { @@ -2937,37 +2935,6 @@ var DefaultBrowserCheck = { #endif try { ShellService.setDefaultBrowser(claimAllTypes, false); - - if (this._setAsDefaultTimer) { - this._setAsDefaultTimer.cancel(); - } - - this._setAsDefaultButtonClickStartTime = Math.floor(Date.now() / 1000); - this._setAsDefaultTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer); - this._setAsDefaultTimer.init(() => { - let isDefault = false; - let isDefaultError = false; - try { - isDefault = ShellService.isDefaultBrowser(true, false); - } catch (ex) { - isDefaultError = true; - } - - let now = Math.floor(Date.now() / 1000); - let runTime = now - this._setAsDefaultButtonClickStartTime; - if (isDefault || runTime > 600) { - this._setAsDefaultTimer.cancel(); - this._setAsDefaultTimer = null; -/* - Services.telemetry.getHistogramById("BROWSER_SET_DEFAULT_TIME_TO_COMPLETION_SECONDS") - .add(runTime); -*/ - } -/* - Services.telemetry.getHistogramById("BROWSER_IS_USER_DEFAULT_ERROR") - .add(isDefaultError); -*/ - }, 1000, Ci.nsITimer.TYPE_REPEATING_SLACK); } catch (ex) { setAsDefaultError = true; Cu.reportError(ex); diff --git a/js/src/proxy/Wrapper.cpp b/js/src/proxy/Wrapper.cpp index da00fce5b..e15593575 100644 --- a/js/src/proxy/Wrapper.cpp +++ b/js/src/proxy/Wrapper.cpp @@ -95,7 +95,7 @@ JS_FRIEND_API(JSObject*) js::UnwrapOneChecked(JSObject* obj, bool stopAtWindowProxy) { if (!obj->is() || - MOZ_UNLIKELY(IsWindowProxy(obj) && stopAtWindowProxy)) + MOZ_UNLIKELY(stopAtWindowProxy && IsWindowProxy(obj))) { return obj; }