From 26c0c66ab7af133b2b1b4edb5831d59d13a37853 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20Fr=C3=BChwirth?= Date: Mon, 16 May 2022 12:47:10 +0200 Subject: [PATCH] Comment out parameter names from virtual functions to silence unused parameter compiler warnings with -Wextra (-Wunused-parameter) --- src/conv/binhex.cc | 6 +++--- src/fs/file.cc | 3 +-- src/stuffit/methods.cc | 2 +- src/stuffit/methods.h | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/conv/binhex.cc b/src/conv/binhex.cc index c9f7c56..c46a647 100644 --- a/src/conv/binhex.cc +++ b/src/conv/binhex.cc @@ -27,7 +27,7 @@ namespace conv { // Return true if a file is in BinHex format. -bool IsFileBinHex(fs::FileReader &reader) +bool IsFileBinHex(fs::FileReader &/* reader */) { // TODO. @@ -37,7 +37,7 @@ bool IsFileBinHex(fs::FileReader &reader) // Read and decode a BinHex file. -void ReadBinHex(fs::FileReader &reader, fs::File &file) +void ReadBinHex(fs::FileReader &/* reader */, fs::File &/* file */) { // TODO. } @@ -45,7 +45,7 @@ void ReadBinHex(fs::FileReader &reader, fs::File &file) // Write a BinHex file. -void WriteBinHex(fs::File &file, fs::FileWriter &writer) +void WriteBinHex(fs::File &/* file */, fs::FileWriter &/* writer */) { // TODO. } diff --git a/src/fs/file.cc b/src/fs/file.cc index cb714bd..4c296bc 100644 --- a/src/fs/file.cc +++ b/src/fs/file.cc @@ -71,13 +71,12 @@ int ReadLocalFile(const std::string &filename, fs::DataPtr &ptr) // Get file infotmation from a local file. -void GetLocalInfo(const std::string &filename, fs::File &file, bool is_res) +void GetLocalInfo(const std::string & /*filename */, fs::File &/* file */, bool /* is_res */) { // TODO. } - // Set file infotmation to a local file. void SetLocalInfo(fs::File &file, const std::string &filename, bool is_res) { diff --git a/src/stuffit/methods.cc b/src/stuffit/methods.cc index 5fc9891..5517000 100644 --- a/src/stuffit/methods.cc +++ b/src/stuffit/methods.cc @@ -89,7 +89,7 @@ void CompressionMethod::Extract(const StuffitCompInfo &info, uint8_t *data, // Extract data from the compressed fork. void NoneMethod::Extract(const StuffitCompInfo &info, uint8_t *data, - std::vector &mem_pool) + std::vector &/* mem_pool */) { total_size = info.size ? info.size : info.comp_size; uncompressed = data + info.offset; diff --git a/src/stuffit/methods.h b/src/stuffit/methods.h index 155fb37..2562f27 100644 --- a/src/stuffit/methods.h +++ b/src/stuffit/methods.h @@ -47,7 +47,7 @@ struct CompressionMethod { // Read the next bytes. - virtual int32_t ReadBytes(uint8_t *data, uint32_t length) { return -1; } + virtual int32_t ReadBytes(uint8_t * /* data */, uint32_t /* length */) { return -1; } // Initialize the algorithm. virtual void Initialize() {}