diff --git a/Elf2Mac/Section.cc b/Elf2Mac/Section.cc index 677fc255e3..bda3e75420 100644 --- a/Elf2Mac/Section.cc +++ b/Elf2Mac/Section.cc @@ -211,6 +211,9 @@ void Section::FixRelocs(bool allowDirectCodeRefs) case SectionKind::bss: relocBase = RelocBase::bss; break; + case SectionKind::undefined: + assert(false); + break; } rela.relocBase = relocBase; diff --git a/LaunchAPPL/Common/ReliableStream.cc b/LaunchAPPL/Common/ReliableStream.cc index 43aedbb7a7..f1d1149571 100644 --- a/LaunchAPPL/Common/ReliableStream.cc +++ b/LaunchAPPL/Common/ReliableStream.cc @@ -1,6 +1,7 @@ #include "ReliableStream.h" #include #include "CRC32.h" +#include using std::begin; using std::end; @@ -460,4 +461,5 @@ size_t ReliableStream::onReceive(const uint8_t* p, size_t n) } break; } + assert(false); } diff --git a/LaunchAPPL/Common/ReliableStream.h b/LaunchAPPL/Common/ReliableStream.h index 5fd8cff5f3..3aeb49853d 100644 --- a/LaunchAPPL/Common/ReliableStream.h +++ b/LaunchAPPL/Common/ReliableStream.h @@ -45,7 +45,7 @@ class ReliableStream : public StreamWrapper bool resetResponse = false; bool flushRequested = false; - virtual size_t onReceive(const uint8_t* p, size_t n); + virtual size_t onReceive(const uint8_t* p, size_t n) override; public: explicit ReliableStream(Stream* stream); void reset(int sendReset); diff --git a/LaunchAPPL/Common/Stream.cc b/LaunchAPPL/Common/Stream.cc index 68aabae1cc..eea77847b1 100644 --- a/LaunchAPPL/Common/Stream.cc +++ b/LaunchAPPL/Common/Stream.cc @@ -84,4 +84,5 @@ StreamWrapper& StreamWrapper::operator=(StreamWrapper&& other) if(underlying_) underlying_->setListener(this); other.underlying_ = nullptr; + return *this; } diff --git a/Rez/ResourceDefinitions.h b/Rez/ResourceDefinitions.h index e3b27f91e9..7b59d4d8a5 100644 --- a/Rez/ResourceDefinitions.h +++ b/Rez/ResourceDefinitions.h @@ -47,6 +47,8 @@ class Field public: yy::location location; + virtual ~Field() = default; + virtual bool needsValue() { return true; } virtual void compile(ExprPtr expr, ResourceCompiler *compiler, bool prePass) = 0; diff --git a/Rez/RezLexer.cc b/Rez/RezLexer.cc index 3626d639d5..d313f0f603 100644 --- a/Rez/RezLexer.cc +++ b/Rez/RezLexer.cc @@ -166,7 +166,7 @@ RezLexer::WaveToken RezLexer::nextWave() return tok; } } - catch(preprocess_exception e) + catch(const preprocess_exception& e) { curFile = e.file_name(); auto yypos = yy::position(&curFile, e.line_no(), e.column_no()); diff --git a/libelf/src/config.h b/libelf/src/config.h index 13e8bdb026..5a6219d9ee 100644 --- a/libelf/src/config.h +++ b/libelf/src/config.h @@ -52,9 +52,6 @@ # define rwlock_unlock(lock) ((void) (lock)) #endif /* USE_LOCKS */ -/* gettext helper macro. */ -#define N_(Str) Str - /* Compiler-specific definitions. */ //#define strong_alias(name, aliasname) \ // extern __typeof (name) aliasname __attribute__ ((alias (#name)));