From 1504bd22279b3d9f7b7df06d8195a8425028f62e Mon Sep 17 00:00:00 2001 From: joevt Date: Sun, 10 Mar 2024 16:18:48 -0700 Subject: [PATCH] sc53c94: Move DATA_FIFO_MAX from header. Headers shouldn't make defines that are not meant to be used outside the source file. --- devices/common/scsi/sc53c94.cpp | 2 ++ devices/common/scsi/sc53c94.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/devices/common/scsi/sc53c94.cpp b/devices/common/scsi/sc53c94.cpp index 500b0f5..9c395de 100644 --- a/devices/common/scsi/sc53c94.cpp +++ b/devices/common/scsi/sc53c94.cpp @@ -376,6 +376,8 @@ void Sc53C94::exec_next_command() } } +#define DATA_FIFO_MAX 16 + void Sc53C94::fifo_push(const uint8_t data) { if (this->data_fifo_pos < DATA_FIFO_MAX) { diff --git a/devices/common/scsi/sc53c94.h b/devices/common/scsi/sc53c94.h index 7d51152..8595806 100644 --- a/devices/common/scsi/sc53c94.h +++ b/devices/common/scsi/sc53c94.h @@ -38,8 +38,6 @@ along with this program. If not, see . class DmaBidirChannel; class InterruptCtrl; -#define DATA_FIFO_MAX 16 - /** 53C94 read registers */ namespace Read { enum Reg53C94 : uint8_t {