From cf4913deb01b3ef7ce90081d6078798c464f875d Mon Sep 17 00:00:00 2001 From: Mihai Parparita Date: Mon, 8 Apr 2024 15:41:19 -0500 Subject: [PATCH] bandit: Fix regression in non-Aspen PCI bridge Refactor from e7da98b6bddbce0208d890ba23ed55d07d05b119 accidentally made the non-Aspen PCI code path for CONFIG_ADDR writes by a no-op. --- devices/common/pci/bandit.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/devices/common/pci/bandit.cpp b/devices/common/pci/bandit.cpp index 5e6f299..999cea2 100644 --- a/devices/common/pci/bandit.cpp +++ b/devices/common/pci/bandit.cpp @@ -193,10 +193,7 @@ void BanditHost::write(uint32_t rgn_start, uint32_t offset, uint32_t value, int break; case 2: // CONFIG_ADDR - if (this->is_aspen) - this->config_addr = value; - else - BYTESWAP_32(value); + this->config_addr = (this->is_aspen) ? value : BYTESWAP_32(value); break; default: // I/O space