Macintosh-Tools/dingusppc
1
0
Fork 0
mirror of https://github.com/dingusdev/dingusppc.git synced 2024-12-25 18:29:49 +00:00
Code Issues Projects Releases Wiki Activity

ppcopcodes: Fix l*ux? invalid form check.

Browse Source 
Invalid form is (reg_a == reg_d) || reg_a == 0.
Therefore, valid form is (reg_a != reg_d) && reg_a != 0
!(a || b) == !a && !b
This commit is contained in:
joevt 2024-01-10 05:51:14 -08:00 committed by dingusdev
parent 996857b10d
commit d0b0b8070c
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
cpu/ppc/ppcopcodes.cpp
View File

@ -1808,7 +1808,7 @@ void dppc_interpreter::ppc_lbzu() {
#endif #endif
ppc_grab_regsda(); ppc_grab_regsda();
ppc_effective_address = int32_t(int16_t(ppc_cur_instruction)); ppc_effective_address = int32_t(int16_t(ppc_cur_instruction));
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address += ppc_result_a; ppc_effective_address += ppc_result_a;
//ppc_result_d = mem_grab_byte(ppc_effective_address); //ppc_result_d = mem_grab_byte(ppc_effective_address);
ppc_result_d = mmu_read_vmem<uint8_t>(ppc_effective_address); ppc_result_d = mmu_read_vmem<uint8_t>(ppc_effective_address);
@ -1836,7 +1836,7 @@ void dppc_interpreter::ppc_lbzux() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsdab(); ppc_grab_regsdab();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = ppc_result_a + ppc_result_b; ppc_effective_address = ppc_result_a + ppc_result_b;
//ppc_result_d = mem_grab_byte(ppc_effective_address); //ppc_result_d = mem_grab_byte(ppc_effective_address);
ppc_result_d = mmu_read_vmem<uint8_t>(ppc_effective_address); ppc_result_d = mmu_read_vmem<uint8_t>(ppc_effective_address);
@ -1866,7 +1866,7 @@ void dppc_interpreter::ppc_lhzu() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsda(); ppc_grab_regsda();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = int32_t(int16_t(ppc_cur_instruction)); ppc_effective_address = int32_t(int16_t(ppc_cur_instruction));
ppc_effective_address += ppc_result_a; ppc_effective_address += ppc_result_a;
//ppc_result_d = mem_grab_word(ppc_effective_address); //ppc_result_d = mem_grab_word(ppc_effective_address);
@ -1895,7 +1895,7 @@ void dppc_interpreter::ppc_lhzux() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsdab(); ppc_grab_regsdab();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = ppc_result_a + ppc_result_b; ppc_effective_address = ppc_result_a + ppc_result_b;
//ppc_result_d = mem_grab_word(ppc_effective_address); //ppc_result_d = mem_grab_word(ppc_effective_address);
ppc_result_d = mmu_read_vmem<uint16_t>(ppc_effective_address); ppc_result_d = mmu_read_vmem<uint16_t>(ppc_effective_address);
@ -1925,7 +1925,7 @@ void dppc_interpreter::ppc_lhau() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsda(); ppc_grab_regsda();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = int32_t(int16_t(ppc_cur_instruction)); ppc_effective_address = int32_t(int16_t(ppc_cur_instruction));
ppc_effective_address += ppc_result_a; ppc_effective_address += ppc_result_a;
//uint16_t val = mem_grab_word(ppc_effective_address); //uint16_t val = mem_grab_word(ppc_effective_address);
@ -1944,7 +1944,7 @@ void dppc_interpreter::ppc_lhaux() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsdab(); ppc_grab_regsdab();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = ppc_result_a + ppc_result_b; ppc_effective_address = ppc_result_a + ppc_result_b;
// uint16_t val = mem_grab_word(ppc_effective_address); // uint16_t val = mem_grab_word(ppc_effective_address);
uint16_t val = mmu_read_vmem<uint16_t>(ppc_effective_address); uint16_t val = mmu_read_vmem<uint16_t>(ppc_effective_address);
@ -2010,7 +2010,7 @@ void dppc_interpreter::ppc_lwzu() {
#endif #endif
ppc_grab_regsda(); ppc_grab_regsda();
ppc_effective_address = int32_t(int16_t(ppc_cur_instruction)); ppc_effective_address = int32_t(int16_t(ppc_cur_instruction));
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address += ppc_result_a; ppc_effective_address += ppc_result_a;
//ppc_result_d = mem_grab_dword(ppc_effective_address); //ppc_result_d = mem_grab_dword(ppc_effective_address);
ppc_result_d = mmu_read_vmem<uint32_t>(ppc_effective_address); ppc_result_d = mmu_read_vmem<uint32_t>(ppc_effective_address);
@ -2038,7 +2038,7 @@ void dppc_interpreter::ppc_lwzux() {
num_int_loads++; num_int_loads++;
#endif #endif
ppc_grab_regsdab(); ppc_grab_regsdab();
if ((reg_a != reg_d) || reg_a != 0) { if ((reg_a != reg_d) && reg_a != 0) {
ppc_effective_address = ppc_result_a + ppc_result_b; ppc_effective_address = ppc_result_a + ppc_result_b;
// ppc_result_d = mem_grab_dword(ppc_effective_address); // ppc_result_d = mem_grab_dword(ppc_effective_address);
ppc_result_d = mmu_read_vmem<uint32_t>(ppc_effective_address); ppc_result_d = mmu_read_vmem<uint32_t>(ppc_effective_address);