6502/6502bench
1
0
Fork 0
mirror of https://github.com/fadden/6502bench.git synced 2026-04-19 12:25:05 +00:00
Code Issues Projects Releases Wiki Activity

Tweak EditInstructionOperand dialog

Browse Source 
Don't need both Checked and Unchecked events for radio buttons.  If
you act on both you end up doing everything 2x whenever the
selection changes.
This commit is contained in:
Andy McFadden
2019-07-10 12:57:18 -07:00
parent 300b2a4bca
commit 05d61cfebd
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SourceGenWPF/WpfGui/EditInstructionOperand.xaml
+9 -9
View File
@@ -29,15 +29,15 @@ limitations under the License.
<StackPanel Margin="8">
<TextBlock Text="Select operand format:"/>
<RadioButton Name="defaultButton" GroupName="Format" Content="Default" Margin="0,2,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="hexButton" GroupName="Format" Content="Hexadecimal" Margin="0,2,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="decimalButton" GroupName="Format" Content="Decimal" Margin="0,2,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="binaryButton" GroupName="Format" Content="Binary" Margin="0,2,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="asciiButton" GroupName="Format" Content="ASCII character" Margin="0,2,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<Grid>
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto"/>
@@ -49,16 +49,16 @@ limitations under the License.
</Grid.RowDefinitions>
<RadioButton Name="symbolButton" Grid.Column="0" Grid.Row="0" Margin="0,2,0,0"
GroupName="Format" Content="Symbol"
Checked="MainGroup_CheckedChanged" Unchecked="MainGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<TextBox Name="symbolTextBox" Grid.Column="1" Grid.Row="0" Margin="8,1,0,0"
FontFamily="{StaticResource GeneralMonoFont}" TextChanged="SymbolTextBox_TextChanged"/>
<StackPanel Name="symbolPartPanel" Grid.Column="1" Grid.Row="1" Orientation="Horizontal" Margin="8,4,0,0">
<RadioButton Name="lowButton" GroupName="Part" Content="Low"
Checked="MainGroup_CheckedChanged" Unchecked="PartGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="highButton" GroupName="Part" Content="High" Margin="8,0,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="PartGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
<RadioButton Name="bankButton" GroupName="Part" Content="Bank" Margin="8,0,0,0"
Checked="MainGroup_CheckedChanged" Unchecked="PartGroup_CheckedChanged"/>
Checked="MainGroup_CheckedChanged"/>
</StackPanel>
</Grid>
SourceGenWPF/WpfGui/EditInstructionOperand.xaml.cs
+2
View File
@@ -428,6 +428,8 @@ namespace SourceGenWPF.WpfGui {
ShortcutArg = mAttr.OperandAddress;
} else {
// Probably an immediate operand.
// ?? Should operandAndProjButton be enabled for 8-bit constants? We'd want
// to add it as a constant rather than an address.
labelInsteadButton.IsEnabled = operandAndLabelButton.IsEnabled =
operandAndProjButton.IsEnabled = false;
}