6502/6502bench
1
0
Fork 0
mirror of https://github.com/fadden/6502bench.git synced 2024-12-03 05:49:48 +00:00
Code Issues Projects Releases Wiki Activity

Fix keyboard nav after selection jump

Browse Source 
If you change the selection by double-clicking in one of the side
windows (References, Notes, Symbols, Messages) and then attempt
to navigate with the arrow keys, the program will appear to hang
briefly, then jump to the start or end of the project and shift the
window focus to something else (like the Help menu in the menu bar).

For reasons I don't fully understand, the behavior is fixed by
removing unnecessary calls to codeListView.Focus().  The calls were
intended to shift input focus to the main ListView, but they're no
longer necessary, and appear to upset WPF.

(issue #113)
This commit is contained in:
Andy McFadden 2021-10-25 15:45:42 -07:00
parent c59ad5b426
commit a04557762d
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
SourceGen/WpfGui/MainWindow.xaml.cs
View File

@ -1030,9 +1030,9 @@ namespace SourceGen.WpfGui {
/// Generally don't call this: it puts the focus on the control, not the items in the
/// control, so if you use up/down arrows you move to the next control.
/// </remarks>
public void CodeListView_Focus() {
codeListView.Focus();
}
//public void CodeListView_Focus() {
// codeListView.Focus();
//}
#endregion Selection management
@ -1686,7 +1686,7 @@ namespace SourceGen.WpfGui {
// Jump to the offset, then shift the focus back to the code list.
mMainCtrl.GoToLocation(new NavStack.Location(rli.OffsetValue, 0,
NavStack.GoToMode.JumpToCodeData), true);
codeListView.Focus();
//codeListView.Focus();
}
#endregion References panel
@ -1730,7 +1730,7 @@ namespace SourceGen.WpfGui {
// Jump to the offset, then shift the focus back to the code list.
mMainCtrl.GoToLocation(new NavStack.Location(nli.OffsetValue, 0,
NavStack.GoToMode.JumpToNote), true);
codeListView.Focus();
//codeListView.Focus();
}
#endregion Notes panel
@ -1858,7 +1858,7 @@ namespace SourceGen.WpfGui {
// TODO: this should also work for project/platform symbols that have EQU directives
mMainCtrl.GoToLabel(sli.Sym);
codeListView.Focus();
//codeListView.Focus();
}
private void SymbolsList_Filter(object sender, FilterEventArgs e) {
@ -2112,7 +2112,7 @@ namespace SourceGen.WpfGui {
// Jump to the offset, then shift the focus back to the code list.
mMainCtrl.GoToLocation(new NavStack.Location(mli.OffsetValue, 0,
NavStack.GoToMode.JumpToCodeData), true);
codeListView.Focus();
//codeListView.Focus();
}
/// <summary>