6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2026-03-13 19:16:40 +00:00
Code Issues Projects Releases Wiki Activity

Correct clamping when converting to a type with a wider range.

Browse Source
This commit is contained in:
Thomas Harte
2026-02-15 17:39:21 -05:00
parent 8c90aa72c8
commit 3840a6d170
1 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
ClockReceiver/ClockReceiver.hpp
View File

@@ -134,9 +134,9 @@ public:
// bool operator () is not supported because it offers an implicit cast to int,
// which is prone silently to permit misuse.
/// @returns The underlying int, converted to an integral type of your choosing, clamped to that int's range.
template<typename Type = IntType> forceinline constexpr Type as() const {
if constexpr (sizeof(Type) == sizeof(IntType)) {
/// @returns The underlying int, converted to a numeric type of your choosing, clamped to that type's range.
template<typename Type = IntType> constexpr Type as() const {
if constexpr (sizeof(Type) == sizeof(IntType) && std::is_integral_v<Type>) {
if constexpr (std::is_same_v<Type, IntType>) {
return length_;
} else if constexpr (std::is_signed_v<Type>) {
@@ -150,12 +150,7 @@ public:
}
}
const auto clamped = std::clamp(
length_,
IntType(std::numeric_limits<Type>::min()),
IntType(std::numeric_limits<Type>::max())
);
return Type(clamped);
return Type(std::clamp(length_, low<Type>, high<Type>));
}
/// @returns The underlying int, in its native form.
@@ -188,6 +183,22 @@ public:
protected:
IntType length_;
private:
template <typename Type>
static consteval bool can_represent(const Type x) {
return std::numeric_limits<IntType>::min() <= x && std::numeric_limits<IntType>::max() >= x;
}
template<typename Type>
static constexpr IntType low =
can_represent(std::numeric_limits<Type>::min()) ?
IntType(std::numeric_limits<Type>::min()) : std::numeric_limits<IntType>::min();
template<typename Type>
static constexpr IntType high =
can_represent(std::numeric_limits<Type>::max()) ?
IntType(std::numeric_limits<Type>::max()) : std::numeric_limits<IntType>::max();
};
/// Describes an integer number of whole cycles: pairs of clock signal transitions.