6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2026-04-26 03:29:40 +00:00
Code Issues Projects Releases Wiki Activity

Make a reasoned decision on luma sharpening.

Browse Source
This commit is contained in:
Thomas Harte
2026-01-18 20:30:43 -05:00
parent db163ec362
commit 9f7adc25e3
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Outputs/ScanTargets/FilterGenerator.cpp
+10 -15
View File
@@ -33,7 +33,9 @@ FilterGenerator::FilterPair FilterGenerator::separation_filter() {
SignalProcessing::KaiserBessel::filter<SignalProcessing::ScalarType::Float>(
MaxKernelSize,
samples_per_line_,
10.0f,
subcarrier_frequency_ / 6.0f, // Based on the broad logic that artefact colour 'sort of' assumes that
// subcarrier_frequency_/4 pixels won't be discernable, and /6 is a bit
// smaller than that. Hands are suitably waved.
subcarrier_frequency_ * 0.5f
);
@@ -63,20 +65,13 @@ FilterGenerator::FilterPair FilterGenerator::separation_filter() {
FilterGenerator::FilterPair FilterGenerator::demouldation_filter() {
FilterPair result{};
if(decoding_path_ == DecodingPath::SVideo) {
// S-Video: don't filter luminance at all.
const float identity[] = { 1.0f };
result.luma =
SignalProcessing::FIRFilter<SignalProcessing::ScalarType::Float>(
std::begin(identity),
std::end(identity)
);
} else {
// Composite: sharpen the luminance a touch.
result.luma =
SignalProcessing::KaiserBessel::filter<SignalProcessing::ScalarType::Float>(
MaxKernelSize, samples_per_line_, 30.0f, subcarrier_frequency_);
}
// Don't filter luminance at all.
const float identity[] = { 1.0f };
result.luma =
SignalProcessing::FIRFilter<SignalProcessing::ScalarType::Float>(
std::begin(identity),
std::end(identity)
);
result.chroma =
SignalProcessing::KaiserBessel::filter<SignalProcessing::ScalarType::Float>(