6502/cc65
1
0
Fork 0
mirror of https://github.com/cc65/cc65.git synced 2025-01-17 20:30:36 +00:00
Code Issues Projects Releases Wiki Activity

Address code review comments

Browse Source
This commit is contained in:
Colin Leroy-Mira 2023-10-03 13:34:02 +02:00 committed by Oliver Schmidt
parent e16a5e0dbe
commit 996a2659d5
3 changed files with 74 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/apple2.sgml
View File

@ -428,7 +428,7 @@ The names in the parentheses denote the symbols to be used for static linking of
<tag><tt/a2.ssc.ser (a2_ssc_ser)/</tag>
Driver for the Apple&nbsp;II Super Serial Card.
They are extension cards for the II, II+, IIe, and the Apple //c and //c+ have
The SSC is an extension card for the II, II+, IIe; the Apple //c and //c+ have
the same hardware and firmware integrated.
It supports up to 9600 baud, requires hardware flow control (RTS/CTS) and
does interrupt driven receives. Speeds faster than 9600 baud aren't reachable

2
doc/apple2enh.sgml
View File

@ -429,7 +429,7 @@ The names in the parentheses denote the symbols to be used for static linking of
<tag><tt/a2e.ssc.ser (a2e_ssc_ser)/</tag>
Driver for the Apple&nbsp;II Super Serial Card.
They are extension cards for the II, II+, IIe, and the Apple //c and //c+ have
The SSC is an extension card for the II, II+, IIe; the Apple //c and //c+ have
the same hardware and firmware integrated.
It supports up to 9600 baud, requires hardware flow control (RTS/CTS) and
does interrupt driven receives. Speeds faster than 9600 baud aren't reachable

17
libsrc/apple2/ser/a2.gs.s
View File

@ -73,7 +73,7 @@ CurChanIrqFlags:.byte INTR_PENDING_RX_EXT_B
SerFlagOrig: .byte $00
; Tables used to translate RS232 params into register values
; Tables used to translate cc65 RS232 params into register values
; (Ref page 5-18 and 5-19)
BaudLowTable:
.byte $7E ; SER_BAUD_300
@ -100,6 +100,7 @@ RxBitTable:
.byte %10000000 ; SER_BITS_6 (Ref page 5-7)
.byte %01000000 ; SER_BITS_7
.byte %11000000 ; SER_BITS_8
TxBitTable:
.byte %00000000 ; SER_BITS_5, in WR_TX_CTRL (WR5)
.byte %01000000 ; SER_BITS_6 (Ref page 5-9)
@ -135,18 +136,21 @@ BaudTable: ; bit7 = 1 means setting is invalid
StopTable:
.byte %00000100 ; SER_STOP_1, in WR_TX_RX_CTRL (WR4)
.byte %00001100 ; SER_STOP_2 (Ref page 5-8)
ParityTable:
.byte %00000000 ; SER_PAR_NONE, in WR_TX_RX_CTRL (WR4)
.byte %00000001 ; SER_PAR_ODD (Ref page 5-8)
.byte %00000011 ; SER_PAR_EVEN
.byte $FF ; SER_PAR_MARK
.byte $FF ; SER_PAR_SPACE
IdOfsTable:
.byte $00 ; First firmware instruction
.byte $05 ; Pascal 1.0 ID byte
.byte $07 ; Pascal 1.0 ID byte
.byte $0B ; Pascal 1.1 generic signature byte
.byte $0C ; Device signature byte
IdValTable:
.byte $E2 ; SEP instruction
.byte $38 ; Fixed
@ -345,7 +349,7 @@ NoDevice:
lda #SER_ERR_NO_DEVICE
SetupErrOut:
cli
ldx #$00 ; Return value is char
ldx #$00
stx Slot ; Mark port closed
rts
@ -513,8 +517,9 @@ SER_GET:
inc RecvHead
inc RecvFreeCnt
sta (ptr1)
ldx #$00
txa ; Return code = 0
lda #SER_ERR_OK
.assert SER_ERR_OK = 0, error
tax
rts
NoData:
lda #SER_ERR_NO_DATA
@ -539,7 +544,7 @@ SER_PUT:
: ldy SendFreeCnt ; Do we have room to store byte?
bne :+
lda #SER_ERR_OVERFLOW
ldx #$00 ; Return value is char
ldx #$00
rts
: ldy SendTail ; Put byte into send buffer & send
@ -590,7 +595,7 @@ SER_IOCTL:
rts
: lda #SER_ERR_INV_IOCTL
ldx #$00 ; Return value is char
ldx #$00
rts
;----------------------------------------------------------------------------