6502/cc65
1
0
Fork 0
mirror of https://github.com/cc65/cc65.git synced 2024-12-24 11:31:31 +00:00
Code Issues Projects Releases Wiki Activity

LoadExpr: Set CF_FORCECHAR if test is required

Browse Source 
If we are testing, we do not need to load the high byte(s).
This commit is contained in:
Jesse Rosenstock 2020-08-02 09:03:21 +02:00 committed by Oliver Schmidt
parent 2a555d198c
commit adda28f5c5
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/cc65/loadexpr.c
View File

@ -127,13 +127,20 @@ void LoadExpr (unsigned Flags, struct ExprDesc* Expr)
Flags |= TypeOf (Expr->Type); Flags |= TypeOf (Expr->Type);
} }
/* Setting CF_TEST will cause the load to perform optimizations and not actually load all if (ED_NeedsTest (Expr)) {
** bits of the bit-field, instead just computing the condition codes. Therefore, if /* If we're only testing, we do not need to promote char to int.
** adjustment is required, we do not set CF_TEST here, but handle it below. ** CF_FORCECHAR does nothing if the type is not CF_CHAR.
*/ */
if (ED_NeedsTest (Expr) && !AdjustBitField) { Flags |= CF_FORCECHAR;
/* Setting CF_TEST will cause the load to perform optimizations and not actually load
** all bits of the bit-field, instead just computing the condition codes. Therefore,
** if adjustment is required, we do not set CF_TEST here, but handle it below.
*/
if (!AdjustBitField) {
Flags |= CF_TEST; Flags |= CF_TEST;
} }
}
/* Load the content of Expr */ /* Load the content of Expr */
switch (ED_GetLoc (Expr)) { switch (ED_GetLoc (Expr)) {
@ -206,7 +213,6 @@ void LoadExpr (unsigned Flags, struct ExprDesc* Expr)
if (AdjustBitField) { if (AdjustBitField) {
/* If the field was loaded as a char, force the shift/mask ops to be char ops. /* If the field was loaded as a char, force the shift/mask ops to be char ops.
** If it is a char, the load has already put 0 in the upper byte, so that can remain. ** If it is a char, the load has already put 0 in the upper byte, so that can remain.
** CF_FORCECHAR does nothing if the type is not CF_CHAR.
*/ */
unsigned F = Flags | CF_FORCECHAR | CF_CONST; unsigned F = Flags | CF_FORCECHAR | CF_CONST;