6502
/
dcc6502
mirror of https://github.com/tcarmelveilleux/dcc6502.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Compare commits

base: 6502:dcc6502_v2.1
Branches Tags
6502:master
6502:dcc6502_v2.1
6502:dcc6502_v2.0
6502:dcc6502_v1.4
...
compare: 6502:master
Branches Tags
6502:master
6502:dcc6502_v2.1
6502:dcc6502_v2.0
6502:dcc6502_v1.4

2 Commits
dcc6502_v2 ... master

Author SHA1 Message Date
Tennessee Carmel-Veilleux 680c212992
Merge pull request #3 from ratherlargerobot/fread-brk-bugfix 
Use fread() return value to count bytes
 2018-09-02 15:28:46 -04:00
Nathan Rosenquist 8b01d8b204 Use fread() return value to count bytes 
This commit changes the behavior of dcc6502, so that it consults the
return value of fread(), and then increments the value of byte_count
by the number returned by fread(), rather than implicitly incrementing
it every time.

Previously, a warning occurred during compilation, because the return value
of fread() was ignored. Instead, the number of bytes in the input file were
counted implicitly by incrementing a byte_count variable after every fread()
call.

Additionally, I created a two-byte test input file consisting of the
bytes #$a9ff, which corresponds to LDA #$FF. When dcc6502 tried to
disassemble this input file, it reported that the file had a size of three
bytes. It reported the first two opcodes correctly, but then incorrectly
displayed a BRK as the third opcode.

After this change, the input file now has a reported size of two bytes,
without the phantom BRK opcode at the end.
 2018-09-01 20:44:41 -04:00
1 changed files with 2 additions and 2 deletions
Show Stats Expand all files Collapse all files

4
dcc6502.c
View File

@ -769,8 +769,8 @@ int main(int argc, char *argv[]) {
byte_count = 0;
while(!feof(input_file) && ((options.org + byte_count) <= 0xFFFFu) && (byte_count < options.max_num_bytes)) {
fread(&buffer[options.org + byte_count], 1, 1, input_file);
byte_count++;
size_t bytes_read = fread(&buffer[options.org + byte_count], 1, 1, input_file);
byte_count += bytes_read;
}
fclose(input_file);