2003-10-12 21:44:18 +00:00
|
|
|
//===- LoopSimplify.cpp - Loop Canonicalization Pass ----------------------===//
|
2005-04-21 23:48:37 +00:00
|
|
|
//
|
2003-10-20 19:43:21 +00:00
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-29 20:36:04 +00:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2005-04-21 23:48:37 +00:00
|
|
|
//
|
2003-10-20 19:43:21 +00:00
|
|
|
//===----------------------------------------------------------------------===//
|
2002-09-26 16:17:31 +00:00
|
|
|
//
|
2003-10-12 21:43:28 +00:00
|
|
|
// This pass performs several transformations to transform natural loops into a
|
|
|
|
// simpler form, which makes subsequent analyses and transformations simpler and
|
|
|
|
// more effective.
|
2003-02-27 20:27:08 +00:00
|
|
|
//
|
|
|
|
// Loop pre-header insertion guarantees that there is a single, non-critical
|
|
|
|
// entry edge from outside of the loop to the loop header. This simplifies a
|
|
|
|
// number of analyses and transformations, such as LICM.
|
|
|
|
//
|
|
|
|
// Loop exit-block insertion guarantees that all exit blocks from the loop
|
|
|
|
// (blocks which are outside of the loop that have predecessors inside of the
|
2003-12-10 17:20:35 +00:00
|
|
|
// loop) only have predecessors from inside of the loop (and are thus dominated
|
|
|
|
// by the loop header). This simplifies transformations such as store-sinking
|
|
|
|
// that are built into LICM.
|
2003-02-27 20:27:08 +00:00
|
|
|
//
|
2003-10-13 00:37:13 +00:00
|
|
|
// This pass also guarantees that loops will have exactly one backedge.
|
|
|
|
//
|
2009-11-05 21:14:46 +00:00
|
|
|
// Indirectbr instructions introduce several complications. If the loop
|
|
|
|
// contains or is entered by an indirectbr instruction, it may not be possible
|
|
|
|
// to transform the loop and make these guarantees. Client code should check
|
|
|
|
// that these conditions are true before relying on them.
|
|
|
|
//
|
2003-02-27 20:27:08 +00:00
|
|
|
// Note that the simplifycfg pass will clean up blocks which are split out but
|
2003-10-12 21:43:28 +00:00
|
|
|
// end up being unnecessary, so usage of this pass should not pessimize
|
|
|
|
// generated code.
|
|
|
|
//
|
|
|
|
// This pass obviously modifies the CFG, but updates loop information and
|
|
|
|
// dominator information.
|
2002-09-26 16:17:31 +00:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2011-02-10 23:38:10 +00:00
|
|
|
#define DEBUG_TYPE "loop-simplify"
|
2002-09-26 16:17:31 +00:00
|
|
|
#include "llvm/Transforms/Scalar.h"
|
2007-10-29 02:30:37 +00:00
|
|
|
#include "llvm/Constants.h"
|
2004-07-29 17:30:56 +00:00
|
|
|
#include "llvm/Instructions.h"
|
2010-03-15 21:25:29 +00:00
|
|
|
#include "llvm/IntrinsicInst.h"
|
2004-03-14 03:59:22 +00:00
|
|
|
#include "llvm/Function.h"
|
2009-07-05 22:41:43 +00:00
|
|
|
#include "llvm/LLVMContext.h"
|
2004-03-14 03:59:22 +00:00
|
|
|
#include "llvm/Type.h"
|
2005-03-25 06:37:22 +00:00
|
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
2011-01-18 04:11:31 +00:00
|
|
|
#include "llvm/Analysis/Dominators.h"
|
2010-11-16 17:41:24 +00:00
|
|
|
#include "llvm/Analysis/InstructionSimplify.h"
|
2009-09-28 14:37:51 +00:00
|
|
|
#include "llvm/Analysis/LoopPass.h"
|
2010-11-16 17:41:24 +00:00
|
|
|
#include "llvm/Analysis/ScalarEvolution.h"
|
2008-04-21 01:28:02 +00:00
|
|
|
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
|
2009-06-27 21:30:38 +00:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
2002-09-26 16:17:31 +00:00
|
|
|
#include "llvm/Support/CFG.h"
|
2010-03-01 17:55:27 +00:00
|
|
|
#include "llvm/Support/Debug.h"
|
2004-09-01 22:55:40 +00:00
|
|
|
#include "llvm/ADT/SetOperations.h"
|
|
|
|
#include "llvm/ADT/SetVector.h"
|
|
|
|
#include "llvm/ADT/Statistic.h"
|
|
|
|
#include "llvm/ADT/DepthFirstIterator.h"
|
2003-12-10 17:20:35 +00:00
|
|
|
using namespace llvm;
|
2003-11-11 22:41:34 +00:00
|
|
|
|
2006-12-19 22:17:40 +00:00
|
|
|
STATISTIC(NumInserted, "Number of pre-header or exit blocks inserted");
|
|
|
|
STATISTIC(NumNested , "Number of nested loops split out");
|
2002-09-26 16:17:31 +00:00
|
|
|
|
2006-12-19 22:17:40 +00:00
|
|
|
namespace {
|
2009-10-25 06:33:48 +00:00
|
|
|
struct LoopSimplify : public LoopPass {
|
2007-05-06 13:37:16 +00:00
|
|
|
static char ID; // Pass identification, replacement for typeid
|
2010-10-19 17:21:58 +00:00
|
|
|
LoopSimplify() : LoopPass(ID) {
|
|
|
|
initializeLoopSimplifyPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
2007-05-01 21:15:47 +00:00
|
|
|
|
2005-03-25 06:37:22 +00:00
|
|
|
// AA - If we have an alias analysis object to update, this is it, otherwise
|
|
|
|
// this is null.
|
|
|
|
AliasAnalysis *AA;
|
2006-02-14 22:34:08 +00:00
|
|
|
LoopInfo *LI;
|
2007-06-21 17:23:45 +00:00
|
|
|
DominatorTree *DT;
|
2010-09-04 02:42:48 +00:00
|
|
|
ScalarEvolution *SE;
|
2009-09-28 14:37:51 +00:00
|
|
|
Loop *L;
|
|
|
|
virtual bool runOnLoop(Loop *L, LPPassManager &LPM);
|
2005-04-21 23:48:37 +00:00
|
|
|
|
2002-09-26 16:17:31 +00:00
|
|
|
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
|
|
|
|
// We need loop information to identify the loops...
|
2010-07-26 18:11:16 +00:00
|
|
|
AU.addRequired<DominatorTree>();
|
2002-09-26 16:17:31 +00:00
|
|
|
AU.addPreserved<DominatorTree>();
|
2010-07-16 17:58:45 +00:00
|
|
|
|
2010-07-26 18:11:16 +00:00
|
|
|
AU.addRequired<LoopInfo>();
|
2010-07-16 17:58:45 +00:00
|
|
|
AU.addPreserved<LoopInfo>();
|
|
|
|
|
2008-06-06 17:50:58 +00:00
|
|
|
AU.addPreserved<AliasAnalysis>();
|
2010-09-04 02:42:48 +00:00
|
|
|
AU.addPreserved<ScalarEvolution>();
|
2005-08-10 02:07:32 +00:00
|
|
|
AU.addPreservedID(BreakCriticalEdgesID); // No critical edges added.
|
2002-09-26 16:17:31 +00:00
|
|
|
}
|
2007-07-19 18:02:32 +00:00
|
|
|
|
2009-11-05 21:14:46 +00:00
|
|
|
/// verifyAnalysis() - Verify LoopSimplifyForm's guarantees.
|
|
|
|
void verifyAnalysis() const;
|
2007-07-19 18:02:32 +00:00
|
|
|
|
2002-09-26 16:17:31 +00:00
|
|
|
private:
|
2009-09-28 14:37:51 +00:00
|
|
|
bool ProcessLoop(Loop *L, LPPassManager &LPM);
|
2004-04-18 22:27:10 +00:00
|
|
|
BasicBlock *RewriteLoopExitBlock(Loop *L, BasicBlock *Exit);
|
2009-07-14 01:37:59 +00:00
|
|
|
BasicBlock *InsertPreheaderForLoop(Loop *L);
|
2009-09-28 14:37:51 +00:00
|
|
|
Loop *SeparateNestedLoop(Loop *L, LPPassManager &LPM);
|
2009-11-05 21:14:46 +00:00
|
|
|
BasicBlock *InsertUniqueBackedgeBlock(Loop *L, BasicBlock *Preheader);
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
void PlaceSplitBlockCarefully(BasicBlock *NewBB,
|
2008-04-21 01:28:02 +00:00
|
|
|
SmallVectorImpl<BasicBlock*> &SplitPreds,
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
Loop *L);
|
2002-09-26 16:17:31 +00:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2008-05-13 00:00:25 +00:00
|
|
|
char LoopSimplify::ID = 0;
|
2011-02-10 23:38:10 +00:00
|
|
|
INITIALIZE_PASS_BEGIN(LoopSimplify, "loop-simplify",
|
2010-10-12 19:48:12 +00:00
|
|
|
"Canonicalize natural loops", true, false)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(DominatorTree)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(LoopInfo)
|
2011-02-10 23:38:10 +00:00
|
|
|
INITIALIZE_PASS_END(LoopSimplify, "loop-simplify",
|
2010-10-07 22:25:06 +00:00
|
|
|
"Canonicalize natural loops", true, false)
|
2008-05-13 00:00:25 +00:00
|
|
|
|
2002-09-26 16:17:31 +00:00
|
|
|
// Publically exposed interface to pass...
|
2010-08-06 18:33:48 +00:00
|
|
|
char &llvm::LoopSimplifyID = LoopSimplify::ID;
|
2009-09-28 14:37:51 +00:00
|
|
|
Pass *llvm::createLoopSimplifyPass() { return new LoopSimplify(); }
|
2002-09-26 16:17:31 +00:00
|
|
|
|
2009-12-18 00:28:43 +00:00
|
|
|
/// runOnLoop - Run down all loops in the CFG (recursively, but we could do
|
2002-09-26 16:17:31 +00:00
|
|
|
/// it in any convenient order) inserting preheaders...
|
|
|
|
///
|
2009-09-28 14:37:51 +00:00
|
|
|
bool LoopSimplify::runOnLoop(Loop *l, LPPassManager &LPM) {
|
|
|
|
L = l;
|
2002-09-26 16:17:31 +00:00
|
|
|
bool Changed = false;
|
2006-02-14 22:34:08 +00:00
|
|
|
LI = &getAnalysis<LoopInfo>();
|
2009-01-28 13:14:17 +00:00
|
|
|
AA = getAnalysisIfAvailable<AliasAnalysis>();
|
2007-06-21 17:23:45 +00:00
|
|
|
DT = &getAnalysis<DominatorTree>();
|
2010-09-04 02:42:48 +00:00
|
|
|
SE = getAnalysisIfAvailable<ScalarEvolution>();
|
2002-09-26 16:17:31 +00:00
|
|
|
|
2009-09-28 14:37:51 +00:00
|
|
|
Changed |= ProcessLoop(L, LPM);
|
2002-09-26 16:17:31 +00:00
|
|
|
|
|
|
|
return Changed;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// ProcessLoop - Walk the loop structure in depth first order, ensuring that
|
|
|
|
/// all loops have preheaders.
|
|
|
|
///
|
2009-09-28 14:37:51 +00:00
|
|
|
bool LoopSimplify::ProcessLoop(Loop *L, LPPassManager &LPM) {
|
2002-09-26 16:17:31 +00:00
|
|
|
bool Changed = false;
|
2006-08-12 05:25:00 +00:00
|
|
|
ReprocessLoop:
|
2009-09-28 14:37:51 +00:00
|
|
|
|
2010-03-10 02:18:48 +00:00
|
|
|
// Check to see that no blocks (other than the header) in this loop have
|
2009-09-28 14:37:51 +00:00
|
|
|
// predecessors that are not in the loop. This is not valid for natural
|
|
|
|
// loops, but can occur if the blocks are unreachable. Since they are
|
|
|
|
// unreachable we can just shamelessly delete those CFG edges!
|
|
|
|
for (Loop::block_iterator BB = L->block_begin(), E = L->block_end();
|
|
|
|
BB != E; ++BB) {
|
|
|
|
if (*BB == L->getHeader()) continue;
|
|
|
|
|
2010-07-22 17:18:03 +00:00
|
|
|
SmallPtrSet<BasicBlock*, 4> BadPreds;
|
|
|
|
for (pred_iterator PI = pred_begin(*BB),
|
|
|
|
PE = pred_end(*BB); PI != PE; ++PI) {
|
2010-07-09 14:02:13 +00:00
|
|
|
BasicBlock *P = *PI;
|
|
|
|
if (!L->contains(P))
|
|
|
|
BadPreds.insert(P);
|
|
|
|
}
|
2009-09-28 14:37:51 +00:00
|
|
|
|
|
|
|
// Delete each unique out-of-loop (and thus dead) predecessor.
|
2010-07-22 17:18:03 +00:00
|
|
|
for (SmallPtrSet<BasicBlock*, 4>::iterator I = BadPreds.begin(),
|
2009-09-28 14:37:51 +00:00
|
|
|
E = BadPreds.end(); I != E; ++I) {
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Deleting edge from dead predecessor "
|
|
|
|
<< (*I)->getName() << "\n");
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2009-09-28 14:37:51 +00:00
|
|
|
// Inform each successor of each dead pred.
|
|
|
|
for (succ_iterator SI = succ_begin(*I), SE = succ_end(*I); SI != SE; ++SI)
|
|
|
|
(*SI)->removePredecessor(*I);
|
|
|
|
// Zap the dead pred's terminator and replace it with unreachable.
|
|
|
|
TerminatorInst *TI = (*I)->getTerminator();
|
|
|
|
TI->replaceAllUsesWith(UndefValue::get(TI->getType()));
|
|
|
|
(*I)->getTerminator()->eraseFromParent();
|
|
|
|
new UnreachableInst((*I)->getContext(), *I);
|
|
|
|
Changed = true;
|
|
|
|
}
|
|
|
|
}
|
2004-03-14 03:59:22 +00:00
|
|
|
|
2010-02-25 06:57:05 +00:00
|
|
|
// If there are exiting blocks with branches on undef, resolve the undef in
|
|
|
|
// the direction which will exit the loop. This will help simplify loop
|
|
|
|
// trip count computations.
|
|
|
|
SmallVector<BasicBlock*, 8> ExitingBlocks;
|
|
|
|
L->getExitingBlocks(ExitingBlocks);
|
|
|
|
for (SmallVectorImpl<BasicBlock *>::iterator I = ExitingBlocks.begin(),
|
|
|
|
E = ExitingBlocks.end(); I != E; ++I)
|
|
|
|
if (BranchInst *BI = dyn_cast<BranchInst>((*I)->getTerminator()))
|
|
|
|
if (BI->isConditional()) {
|
|
|
|
if (UndefValue *Cond = dyn_cast<UndefValue>(BI->getCondition())) {
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Resolving \"br i1 undef\" to exit in "
|
|
|
|
<< (*I)->getName() << "\n");
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2010-02-25 06:57:05 +00:00
|
|
|
BI->setCondition(ConstantInt::get(Cond->getType(),
|
|
|
|
!L->contains(BI->getSuccessor(0))));
|
|
|
|
Changed = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-08-12 04:51:20 +00:00
|
|
|
// Does the loop already have a preheader? If so, don't insert one.
|
2009-07-14 01:37:59 +00:00
|
|
|
BasicBlock *Preheader = L->getLoopPreheader();
|
|
|
|
if (!Preheader) {
|
|
|
|
Preheader = InsertPreheaderForLoop(L);
|
2009-11-05 21:14:46 +00:00
|
|
|
if (Preheader) {
|
2010-06-22 15:08:57 +00:00
|
|
|
++NumInserted;
|
2009-11-05 21:14:46 +00:00
|
|
|
Changed = true;
|
|
|
|
}
|
2002-09-26 16:17:31 +00:00
|
|
|
}
|
|
|
|
|
2003-12-10 17:20:35 +00:00
|
|
|
// Next, check to make sure that all exit nodes of the loop only have
|
|
|
|
// predecessors that are inside of the loop. This check guarantees that the
|
|
|
|
// loop preheader/header will dominate the exit blocks. If the exit block has
|
2006-02-12 01:59:10 +00:00
|
|
|
// predecessors from outside of the loop, split the edge now.
|
2007-08-21 00:31:24 +00:00
|
|
|
SmallVector<BasicBlock*, 8> ExitBlocks;
|
2006-02-12 01:59:10 +00:00
|
|
|
L->getExitBlocks(ExitBlocks);
|
2006-02-14 22:34:08 +00:00
|
|
|
|
2010-02-05 19:20:15 +00:00
|
|
|
SmallSetVector<BasicBlock *, 8> ExitBlockSet(ExitBlocks.begin(),
|
|
|
|
ExitBlocks.end());
|
|
|
|
for (SmallSetVector<BasicBlock *, 8>::iterator I = ExitBlockSet.begin(),
|
2004-07-15 08:20:22 +00:00
|
|
|
E = ExitBlockSet.end(); I != E; ++I) {
|
|
|
|
BasicBlock *ExitBlock = *I;
|
2004-07-15 05:36:31 +00:00
|
|
|
for (pred_iterator PI = pred_begin(ExitBlock), PE = pred_end(ExitBlock);
|
|
|
|
PI != PE; ++PI)
|
2006-02-11 02:13:17 +00:00
|
|
|
// Must be exactly this loop: no subloops, parent loops, or non-loop preds
|
|
|
|
// allowed.
|
2006-02-12 01:59:10 +00:00
|
|
|
if (!L->contains(*PI)) {
|
2009-11-05 21:14:46 +00:00
|
|
|
if (RewriteLoopExitBlock(L, ExitBlock)) {
|
2010-06-22 15:08:57 +00:00
|
|
|
++NumInserted;
|
2009-11-05 21:14:46 +00:00
|
|
|
Changed = true;
|
|
|
|
}
|
2004-07-15 05:36:31 +00:00
|
|
|
break;
|
|
|
|
}
|
2004-07-15 08:20:22 +00:00
|
|
|
}
|
2003-02-27 20:27:08 +00:00
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
// If the header has more than two predecessors at this point (from the
|
|
|
|
// preheader and from multiple backedges), we must adjust the loop.
|
2009-11-05 21:14:46 +00:00
|
|
|
BasicBlock *LoopLatch = L->getLoopLatch();
|
|
|
|
if (!LoopLatch) {
|
2006-08-12 05:25:00 +00:00
|
|
|
// If this is really a nested loop, rip it out into a child loop. Don't do
|
|
|
|
// this for loops with a giant number of backedges, just factor them into a
|
|
|
|
// common backedge instead.
|
2009-11-05 21:14:46 +00:00
|
|
|
if (L->getNumBackEdges() < 8) {
|
2009-09-28 14:37:51 +00:00
|
|
|
if (SeparateNestedLoop(L, LPM)) {
|
2006-08-12 05:25:00 +00:00
|
|
|
++NumNested;
|
|
|
|
// This is a big restructuring change, reprocess the whole loop.
|
|
|
|
Changed = true;
|
|
|
|
// GCC doesn't tail recursion eliminate this.
|
|
|
|
goto ReprocessLoop;
|
|
|
|
}
|
2004-04-13 05:05:33 +00:00
|
|
|
}
|
|
|
|
|
2006-08-12 05:25:00 +00:00
|
|
|
// If we either couldn't, or didn't want to, identify nesting of the loops,
|
|
|
|
// insert a new block that all backedges target, then make it jump to the
|
|
|
|
// loop header.
|
2009-11-05 21:14:46 +00:00
|
|
|
LoopLatch = InsertUniqueBackedgeBlock(L, Preheader);
|
|
|
|
if (LoopLatch) {
|
2010-06-22 15:08:57 +00:00
|
|
|
++NumInserted;
|
2009-11-05 21:14:46 +00:00
|
|
|
Changed = true;
|
|
|
|
}
|
2003-10-13 00:37:13 +00:00
|
|
|
}
|
|
|
|
|
2005-08-10 02:07:32 +00:00
|
|
|
// Scan over the PHI nodes in the loop header. Since they now have only two
|
|
|
|
// incoming values (the loop is canonicalized), we may have simplified the PHI
|
|
|
|
// down to 'X = phi [X, Y]', which should be replaced with 'Y'.
|
|
|
|
PHINode *PN;
|
|
|
|
for (BasicBlock::iterator I = L->getHeader()->begin();
|
|
|
|
(PN = dyn_cast<PHINode>(I++)); )
|
2011-01-02 13:38:21 +00:00
|
|
|
if (Value *V = SimplifyInstruction(PN, 0, DT)) {
|
|
|
|
if (AA) AA->deleteValue(PN);
|
2011-01-11 18:14:50 +00:00
|
|
|
if (SE) SE->forgetValue(PN);
|
2011-01-02 13:38:21 +00:00
|
|
|
PN->replaceAllUsesWith(V);
|
|
|
|
PN->eraseFromParent();
|
|
|
|
}
|
2005-08-10 02:07:32 +00:00
|
|
|
|
2010-01-15 21:55:02 +00:00
|
|
|
// If this loop has multiple exits and the exits all go to the same
|
2009-06-27 21:30:38 +00:00
|
|
|
// block, attempt to merge the exits. This helps several passes, such
|
|
|
|
// as LoopRotation, which do not support loops with multiple exits.
|
|
|
|
// SimplifyCFG also does this (and this code uses the same utility
|
|
|
|
// function), however this code is loop-aware, where SimplifyCFG is
|
|
|
|
// not. That gives it the advantage of being able to hoist
|
|
|
|
// loop-invariant instructions out of the way to open up more
|
|
|
|
// opportunities, and the disadvantage of having the responsibility
|
|
|
|
// to preserve dominator information.
|
2009-11-05 21:48:32 +00:00
|
|
|
bool UniqueExit = true;
|
|
|
|
if (!ExitBlocks.empty())
|
|
|
|
for (unsigned i = 1, e = ExitBlocks.size(); i != e; ++i)
|
|
|
|
if (ExitBlocks[i] != ExitBlocks[0]) {
|
|
|
|
UniqueExit = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (UniqueExit) {
|
2009-06-27 21:30:38 +00:00
|
|
|
for (unsigned i = 0, e = ExitingBlocks.size(); i != e; ++i) {
|
|
|
|
BasicBlock *ExitingBlock = ExitingBlocks[i];
|
|
|
|
if (!ExitingBlock->getSinglePredecessor()) continue;
|
|
|
|
BranchInst *BI = dyn_cast<BranchInst>(ExitingBlock->getTerminator());
|
|
|
|
if (!BI || !BI->isConditional()) continue;
|
|
|
|
CmpInst *CI = dyn_cast<CmpInst>(BI->getCondition());
|
|
|
|
if (!CI || CI->getParent() != ExitingBlock) continue;
|
|
|
|
|
|
|
|
// Attempt to hoist out all instructions except for the
|
|
|
|
// comparison and the branch.
|
|
|
|
bool AllInvariant = true;
|
2009-06-30 01:24:43 +00:00
|
|
|
for (BasicBlock::iterator I = ExitingBlock->begin(); &*I != BI; ) {
|
2009-06-27 21:30:38 +00:00
|
|
|
Instruction *Inst = I++;
|
2010-03-15 21:25:29 +00:00
|
|
|
// Skip debug info intrinsics.
|
|
|
|
if (isa<DbgInfoIntrinsic>(Inst))
|
|
|
|
continue;
|
2009-06-30 01:24:43 +00:00
|
|
|
if (Inst == CI)
|
2009-06-27 21:30:38 +00:00
|
|
|
continue;
|
2009-11-05 21:14:46 +00:00
|
|
|
if (!L->makeLoopInvariant(Inst, Changed,
|
|
|
|
Preheader ? Preheader->getTerminator() : 0)) {
|
2009-06-27 21:30:38 +00:00
|
|
|
AllInvariant = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!AllInvariant) continue;
|
|
|
|
|
|
|
|
// The block has now been cleared of all instructions except for
|
|
|
|
// a comparison and a conditional branch. SimplifyCFG may be able
|
|
|
|
// to fold it now.
|
|
|
|
if (!FoldBranchToCommonDest(BI)) continue;
|
|
|
|
|
|
|
|
// Success. The block is now dead, so remove it from the loop,
|
2011-01-18 04:11:31 +00:00
|
|
|
// update the dominator tree and delete it.
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Eliminating exiting block "
|
|
|
|
<< ExitingBlock->getName() << "\n");
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2009-06-27 21:30:38 +00:00
|
|
|
assert(pred_begin(ExitingBlock) == pred_end(ExitingBlock));
|
|
|
|
Changed = true;
|
2009-06-27 22:32:36 +00:00
|
|
|
LI->removeBlock(ExitingBlock);
|
2009-06-27 21:30:38 +00:00
|
|
|
|
|
|
|
DomTreeNode *Node = DT->getNode(ExitingBlock);
|
|
|
|
const std::vector<DomTreeNodeBase<BasicBlock> *> &Children =
|
|
|
|
Node->getChildren();
|
2009-09-30 20:54:16 +00:00
|
|
|
while (!Children.empty()) {
|
|
|
|
DomTreeNode *Child = Children.front();
|
|
|
|
DT->changeImmediateDominator(Child, Node->getIDom());
|
2009-06-27 21:30:38 +00:00
|
|
|
}
|
|
|
|
DT->eraseNode(ExitingBlock);
|
|
|
|
|
|
|
|
BI->getSuccessor(0)->removePredecessor(ExitingBlock);
|
|
|
|
BI->getSuccessor(1)->removePredecessor(ExitingBlock);
|
|
|
|
ExitingBlock->eraseFromParent();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2002-09-26 16:17:31 +00:00
|
|
|
return Changed;
|
|
|
|
}
|
|
|
|
|
2003-02-27 20:27:08 +00:00
|
|
|
/// InsertPreheaderForLoop - Once we discover that a loop doesn't have a
|
|
|
|
/// preheader, this method is called to insert one. This method has two phases:
|
|
|
|
/// preheader insertion and analysis updating.
|
|
|
|
///
|
2009-07-14 01:37:59 +00:00
|
|
|
BasicBlock *LoopSimplify::InsertPreheaderForLoop(Loop *L) {
|
2003-02-27 20:27:08 +00:00
|
|
|
BasicBlock *Header = L->getHeader();
|
|
|
|
|
|
|
|
// Compute the set of predecessors of the loop that are not in the loop.
|
2008-04-21 01:28:02 +00:00
|
|
|
SmallVector<BasicBlock*, 8> OutsideBlocks;
|
2003-02-27 20:27:08 +00:00
|
|
|
for (pred_iterator PI = pred_begin(Header), PE = pred_end(Header);
|
2010-07-09 14:02:13 +00:00
|
|
|
PI != PE; ++PI) {
|
|
|
|
BasicBlock *P = *PI;
|
|
|
|
if (!L->contains(P)) { // Coming in from outside the loop?
|
2009-11-05 21:14:46 +00:00
|
|
|
// If the loop is branched to from an indirect branch, we won't
|
|
|
|
// be able to fully transform the loop, because it prohibits
|
|
|
|
// edge splitting.
|
2010-07-09 14:02:13 +00:00
|
|
|
if (isa<IndirectBrInst>(P->getTerminator())) return 0;
|
2009-11-05 21:14:46 +00:00
|
|
|
|
|
|
|
// Keep track of it.
|
2010-07-09 14:02:13 +00:00
|
|
|
OutsideBlocks.push_back(P);
|
2009-11-05 21:14:46 +00:00
|
|
|
}
|
2010-07-09 14:02:13 +00:00
|
|
|
}
|
2005-04-21 23:48:37 +00:00
|
|
|
|
2006-09-23 07:40:52 +00:00
|
|
|
// Split out the loop pre-header.
|
2003-02-27 20:27:08 +00:00
|
|
|
BasicBlock *NewBB =
|
2008-04-21 01:28:02 +00:00
|
|
|
SplitBlockPredecessors(Header, &OutsideBlocks[0], OutsideBlocks.size(),
|
|
|
|
".preheader", this);
|
2003-02-27 22:48:57 +00:00
|
|
|
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Creating pre-header " << NewBB->getName()
|
|
|
|
<< "\n");
|
2010-03-01 17:55:27 +00:00
|
|
|
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
// Make sure that NewBB is put someplace intelligent, which doesn't mess up
|
|
|
|
// code layout too horribly.
|
|
|
|
PlaceSplitBlockCarefully(NewBB, OutsideBlocks, L);
|
2009-07-14 01:37:59 +00:00
|
|
|
|
|
|
|
return NewBB;
|
2003-02-27 20:27:08 +00:00
|
|
|
}
|
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
/// RewriteLoopExitBlock - Ensure that the loop preheader dominates all exit
|
|
|
|
/// blocks. This method is used to split exit blocks that have predecessors
|
|
|
|
/// outside of the loop.
|
2004-04-18 22:27:10 +00:00
|
|
|
BasicBlock *LoopSimplify::RewriteLoopExitBlock(Loop *L, BasicBlock *Exit) {
|
2008-04-21 01:28:02 +00:00
|
|
|
SmallVector<BasicBlock*, 8> LoopBlocks;
|
2010-07-09 14:02:13 +00:00
|
|
|
for (pred_iterator I = pred_begin(Exit), E = pred_end(Exit); I != E; ++I) {
|
|
|
|
BasicBlock *P = *I;
|
|
|
|
if (L->contains(P)) {
|
2009-11-05 21:14:46 +00:00
|
|
|
// Don't do this if the loop is exited via an indirect branch.
|
2010-07-09 14:02:13 +00:00
|
|
|
if (isa<IndirectBrInst>(P->getTerminator())) return 0;
|
2009-11-05 21:14:46 +00:00
|
|
|
|
2010-07-09 14:02:13 +00:00
|
|
|
LoopBlocks.push_back(P);
|
2009-11-05 21:14:46 +00:00
|
|
|
}
|
2010-07-09 14:02:13 +00:00
|
|
|
}
|
2003-02-27 20:27:08 +00:00
|
|
|
|
2003-02-27 22:31:07 +00:00
|
|
|
assert(!LoopBlocks.empty() && "No edges coming in from outside the loop?");
|
2008-04-21 01:28:02 +00:00
|
|
|
BasicBlock *NewBB = SplitBlockPredecessors(Exit, &LoopBlocks[0],
|
|
|
|
LoopBlocks.size(), ".loopexit",
|
|
|
|
this);
|
2003-02-27 22:31:07 +00:00
|
|
|
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Creating dedicated exit block "
|
|
|
|
<< NewBB->getName() << "\n");
|
2004-04-18 22:27:10 +00:00
|
|
|
return NewBB;
|
2003-10-13 00:37:13 +00:00
|
|
|
}
|
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
/// AddBlockAndPredsToSet - Add the specified block, and all of its
|
|
|
|
/// predecessors, to the specified set, if it's not already in there. Stop
|
|
|
|
/// predecessor traversal when we reach StopBlock.
|
2007-04-20 20:04:37 +00:00
|
|
|
static void AddBlockAndPredsToSet(BasicBlock *InputBB, BasicBlock *StopBlock,
|
2004-04-13 05:05:33 +00:00
|
|
|
std::set<BasicBlock*> &Blocks) {
|
2007-04-20 20:04:37 +00:00
|
|
|
std::vector<BasicBlock *> WorkList;
|
|
|
|
WorkList.push_back(InputBB);
|
|
|
|
do {
|
|
|
|
BasicBlock *BB = WorkList.back(); WorkList.pop_back();
|
|
|
|
if (Blocks.insert(BB).second && BB != StopBlock)
|
|
|
|
// If BB is not already processed and it is not a stop block then
|
|
|
|
// insert its predecessor in the work list
|
|
|
|
for (pred_iterator I = pred_begin(BB), E = pred_end(BB); I != E; ++I) {
|
|
|
|
BasicBlock *WBB = *I;
|
|
|
|
WorkList.push_back(WBB);
|
|
|
|
}
|
|
|
|
} while(!WorkList.empty());
|
2004-04-13 05:05:33 +00:00
|
|
|
}
|
|
|
|
|
2004-04-13 15:21:18 +00:00
|
|
|
/// FindPHIToPartitionLoops - The first part of loop-nestification is to find a
|
|
|
|
/// PHI node that tells us how to partition the loops.
|
2007-06-08 01:50:32 +00:00
|
|
|
static PHINode *FindPHIToPartitionLoops(Loop *L, DominatorTree *DT,
|
2010-11-18 19:59:41 +00:00
|
|
|
AliasAnalysis *AA, LoopInfo *LI) {
|
2004-09-28 02:40:37 +00:00
|
|
|
for (BasicBlock::iterator I = L->getHeader()->begin(); isa<PHINode>(I); ) {
|
|
|
|
PHINode *PN = cast<PHINode>(I);
|
2004-04-13 15:21:18 +00:00
|
|
|
++I;
|
2011-01-02 13:38:21 +00:00
|
|
|
if (Value *V = SimplifyInstruction(PN, 0, DT)) {
|
|
|
|
// This is a degenerate PHI already, don't modify it!
|
|
|
|
PN->replaceAllUsesWith(V);
|
|
|
|
if (AA) AA->deleteValue(PN);
|
|
|
|
PN->eraseFromParent();
|
|
|
|
continue;
|
|
|
|
}
|
2004-10-17 21:22:38 +00:00
|
|
|
|
|
|
|
// Scan this PHI node looking for a use of the PHI node by itself.
|
|
|
|
for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
|
|
|
|
if (PN->getIncomingValue(i) == PN &&
|
|
|
|
L->contains(PN->getIncomingBlock(i)))
|
|
|
|
// We found something tasty to remove.
|
|
|
|
return PN;
|
2004-04-13 15:21:18 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
// PlaceSplitBlockCarefully - If the block isn't already, move the new block to
|
|
|
|
// right after some 'outside block' block. This prevents the preheader from
|
|
|
|
// being placed inside the loop body, e.g. when the loop hasn't been rotated.
|
|
|
|
void LoopSimplify::PlaceSplitBlockCarefully(BasicBlock *NewBB,
|
2008-04-21 01:28:02 +00:00
|
|
|
SmallVectorImpl<BasicBlock*> &SplitPreds,
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
Loop *L) {
|
|
|
|
// Check to see if NewBB is already well placed.
|
|
|
|
Function::iterator BBI = NewBB; --BBI;
|
|
|
|
for (unsigned i = 0, e = SplitPreds.size(); i != e; ++i) {
|
|
|
|
if (&*BBI == SplitPreds[i])
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If it isn't already after an outside block, move it after one. This is
|
|
|
|
// always good as it makes the uncond branch from the outside block into a
|
|
|
|
// fall-through.
|
|
|
|
|
|
|
|
// Figure out *which* outside block to put this after. Prefer an outside
|
|
|
|
// block that neighbors a BB actually in the loop.
|
|
|
|
BasicBlock *FoundBB = 0;
|
|
|
|
for (unsigned i = 0, e = SplitPreds.size(); i != e; ++i) {
|
|
|
|
Function::iterator BBI = SplitPreds[i];
|
|
|
|
if (++BBI != NewBB->getParent()->end() &&
|
|
|
|
L->contains(BBI)) {
|
|
|
|
FoundBB = SplitPreds[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If our heuristic for a *good* bb to place this after doesn't find
|
|
|
|
// anything, just pick something. It's likely better than leaving it within
|
|
|
|
// the loop.
|
|
|
|
if (!FoundBB)
|
|
|
|
FoundBB = SplitPreds[0];
|
|
|
|
NewBB->moveAfter(FoundBB);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
/// SeparateNestedLoop - If this loop has multiple backedges, try to pull one of
|
|
|
|
/// them out into a nested loop. This is important for code that looks like
|
|
|
|
/// this:
|
|
|
|
///
|
|
|
|
/// Loop:
|
|
|
|
/// ...
|
|
|
|
/// br cond, Loop, Next
|
|
|
|
/// ...
|
|
|
|
/// br cond2, Loop, Out
|
|
|
|
///
|
|
|
|
/// To identify this common case, we look at the PHI nodes in the header of the
|
|
|
|
/// loop. PHI nodes with unchanging values on one backedge correspond to values
|
|
|
|
/// that change in the "outer" loop, but not in the "inner" loop.
|
|
|
|
///
|
|
|
|
/// If we are able to separate out a loop, return the new outer loop that was
|
|
|
|
/// created.
|
|
|
|
///
|
2009-09-28 14:37:51 +00:00
|
|
|
Loop *LoopSimplify::SeparateNestedLoop(Loop *L, LPPassManager &LPM) {
|
2010-11-18 19:59:41 +00:00
|
|
|
PHINode *PN = FindPHIToPartitionLoops(L, DT, AA, LI);
|
2004-04-13 15:21:18 +00:00
|
|
|
if (PN == 0) return 0; // No known way to partition.
|
2004-04-13 05:05:33 +00:00
|
|
|
|
2004-04-13 15:21:18 +00:00
|
|
|
// Pull out all predecessors that have varying values in the loop. This
|
|
|
|
// handles the case when a PHI node has multiple instances of itself as
|
|
|
|
// arguments.
|
2008-04-21 01:28:02 +00:00
|
|
|
SmallVector<BasicBlock*, 8> OuterLoopPreds;
|
2004-04-13 15:21:18 +00:00
|
|
|
for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
|
|
|
|
if (PN->getIncomingValue(i) != PN ||
|
2009-11-20 20:51:18 +00:00
|
|
|
!L->contains(PN->getIncomingBlock(i))) {
|
|
|
|
// We can't split indirectbr edges.
|
|
|
|
if (isa<IndirectBrInst>(PN->getIncomingBlock(i)->getTerminator()))
|
|
|
|
return 0;
|
|
|
|
|
2004-04-13 15:21:18 +00:00
|
|
|
OuterLoopPreds.push_back(PN->getIncomingBlock(i));
|
2009-11-20 20:51:18 +00:00
|
|
|
}
|
2004-04-13 05:05:33 +00:00
|
|
|
|
2010-03-01 17:55:27 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Splitting out a new outer loop\n");
|
|
|
|
|
2010-09-04 02:42:48 +00:00
|
|
|
// If ScalarEvolution is around and knows anything about values in
|
|
|
|
// this loop, tell it to forget them, because we're about to
|
|
|
|
// substantially change it.
|
|
|
|
if (SE)
|
|
|
|
SE->forgetLoop(L);
|
|
|
|
|
2004-04-13 16:23:25 +00:00
|
|
|
BasicBlock *Header = L->getHeader();
|
2008-04-21 01:28:02 +00:00
|
|
|
BasicBlock *NewBB = SplitBlockPredecessors(Header, &OuterLoopPreds[0],
|
|
|
|
OuterLoopPreds.size(),
|
|
|
|
".outer", this);
|
2004-04-13 05:05:33 +00:00
|
|
|
|
Be far more careful when splitting a loop header, either to form a preheader
or when splitting loops with a common header into multiple loops. In particular
the old code would always insert the preheader before the old loop header. This
is disasterous in cases where the loop hasn't been rotated. For example, it can
produce code like:
.. outside the loop...
jmp LBB1_2 #bb13.outer
LBB1_1: #bb1
movsd 8(%esp,%esi,8), %xmm1
mulsd (%edi), %xmm1
addsd %xmm0, %xmm1
addl $24, %edi
incl %esi
jmp LBB1_3 #bb13
LBB1_2: #bb13.outer
leal (%edx,%eax,8), %edi
pxor %xmm1, %xmm1
xorl %esi, %esi
LBB1_3: #bb13
movapd %xmm1, %xmm0
cmpl $4, %esi
jl LBB1_1 #bb1
Note that the loop body is actually LBB1_1 + LBB1_3, which means that the
loop now contains an uncond branch WITHIN it to jump around the inserted
loop header (LBB1_2). Doh.
This patch changes the preheader insertion code to insert it in the right
spot, producing this code:
... outside the loop, fall into the header ...
LBB1_1: #bb13.outer
leal (%edx,%eax,8), %esi
pxor %xmm0, %xmm0
xorl %edi, %edi
jmp LBB1_3 #bb13
LBB1_2: #bb1
movsd 8(%esp,%edi,8), %xmm0
mulsd (%esi), %xmm0
addsd %xmm1, %xmm0
addl $24, %esi
incl %edi
LBB1_3: #bb13
movapd %xmm0, %xmm1
cmpl $4, %edi
jl LBB1_2 #bb1
Totally crazy, no branch in the loop! :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8
2006-09-23 08:19:21 +00:00
|
|
|
// Make sure that NewBB is put someplace intelligent, which doesn't mess up
|
|
|
|
// code layout too horribly.
|
|
|
|
PlaceSplitBlockCarefully(NewBB, OuterLoopPreds, L);
|
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
// Create the new outer loop.
|
|
|
|
Loop *NewOuter = new Loop();
|
|
|
|
|
|
|
|
// Change the parent loop to use the outer loop as its child now.
|
|
|
|
if (Loop *Parent = L->getParentLoop())
|
|
|
|
Parent->replaceChildLoopWith(L, NewOuter);
|
|
|
|
else
|
2006-02-14 22:34:08 +00:00
|
|
|
LI->changeTopLevelLoop(L, NewOuter);
|
2004-04-13 05:05:33 +00:00
|
|
|
|
|
|
|
// L is now a subloop of our outer loop.
|
|
|
|
NewOuter->addChildLoop(L);
|
|
|
|
|
2009-09-28 14:37:51 +00:00
|
|
|
// Add the new loop to the pass manager queue.
|
|
|
|
LPM.insertLoopIntoQueue(NewOuter);
|
|
|
|
|
2008-06-22 20:18:58 +00:00
|
|
|
for (Loop::block_iterator I = L->block_begin(), E = L->block_end();
|
|
|
|
I != E; ++I)
|
|
|
|
NewOuter->addBlockEntry(*I);
|
2004-04-13 05:05:33 +00:00
|
|
|
|
2009-09-08 15:45:00 +00:00
|
|
|
// Now reset the header in L, which had been moved by
|
|
|
|
// SplitBlockPredecessors for the outer loop.
|
|
|
|
L->moveToHeader(Header);
|
|
|
|
|
2004-04-13 05:05:33 +00:00
|
|
|
// Determine which blocks should stay in L and which should be moved out to
|
|
|
|
// the Outer loop now.
|
|
|
|
std::set<BasicBlock*> BlocksInL;
|
2010-07-09 14:02:13 +00:00
|
|
|
for (pred_iterator PI=pred_begin(Header), E = pred_end(Header); PI!=E; ++PI) {
|
|
|
|
BasicBlock *P = *PI;
|
|
|
|
if (DT->dominates(Header, P))
|
|
|
|
AddBlockAndPredsToSet(P, Header, BlocksInL);
|
|
|
|
}
|
2004-04-13 05:05:33 +00:00
|
|
|
|
|
|
|
// Scan all of the loop children of L, moving them to OuterLoop if they are
|
|
|
|
// not part of the inner loop.
|
2007-06-29 02:53:16 +00:00
|
|
|
const std::vector<Loop*> &SubLoops = L->getSubLoops();
|
|
|
|
for (size_t I = 0; I != SubLoops.size(); )
|
|
|
|
if (BlocksInL.count(SubLoops[I]->getHeader()))
|
2004-04-13 05:05:33 +00:00
|
|
|
++I; // Loop remains in L
|
|
|
|
else
|
2007-06-29 02:53:16 +00:00
|
|
|
NewOuter->addChildLoop(L->removeChildLoop(SubLoops.begin() + I));
|
2004-04-13 05:05:33 +00:00
|
|
|
|
|
|
|
// Now that we know which blocks are in L and which need to be moved to
|
|
|
|
// OuterLoop, move any blocks that need it.
|
|
|
|
for (unsigned i = 0; i != L->getBlocks().size(); ++i) {
|
|
|
|
BasicBlock *BB = L->getBlocks()[i];
|
|
|
|
if (!BlocksInL.count(BB)) {
|
|
|
|
// Move this block to the parent, updating the exit blocks sets
|
|
|
|
L->removeBlockFromLoop(BB);
|
2006-02-14 22:34:08 +00:00
|
|
|
if ((*LI)[BB] == L)
|
|
|
|
LI->changeLoopFor(BB, NewOuter);
|
2004-04-13 05:05:33 +00:00
|
|
|
--i;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NewOuter;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
2003-10-13 00:37:13 +00:00
|
|
|
/// InsertUniqueBackedgeBlock - This method is called when the specified loop
|
|
|
|
/// has more than one backedge in it. If this occurs, revector all of these
|
|
|
|
/// backedges to target a new basic block and have that block branch to the loop
|
|
|
|
/// header. This ensures that loops have exactly one backedge.
|
|
|
|
///
|
2009-11-05 21:14:46 +00:00
|
|
|
BasicBlock *
|
|
|
|
LoopSimplify::InsertUniqueBackedgeBlock(Loop *L, BasicBlock *Preheader) {
|
2003-10-13 00:37:13 +00:00
|
|
|
assert(L->getNumBackEdges() > 1 && "Must have > 1 backedge!");
|
|
|
|
|
|
|
|
// Get information about the loop
|
|
|
|
BasicBlock *Header = L->getHeader();
|
|
|
|
Function *F = Header->getParent();
|
|
|
|
|
2009-11-05 21:14:46 +00:00
|
|
|
// Unique backedge insertion currently depends on having a preheader.
|
|
|
|
if (!Preheader)
|
|
|
|
return 0;
|
|
|
|
|
2003-10-13 00:37:13 +00:00
|
|
|
// Figure out which basic blocks contain back-edges to the loop header.
|
|
|
|
std::vector<BasicBlock*> BackedgeBlocks;
|
2010-07-09 16:26:41 +00:00
|
|
|
for (pred_iterator I = pred_begin(Header), E = pred_end(Header); I != E; ++I){
|
|
|
|
BasicBlock *P = *I;
|
2010-08-14 00:43:09 +00:00
|
|
|
|
|
|
|
// Indirectbr edges cannot be split, so we must fail if we find one.
|
|
|
|
if (isa<IndirectBrInst>(P->getTerminator()))
|
|
|
|
return 0;
|
|
|
|
|
2010-07-09 16:26:41 +00:00
|
|
|
if (P != Preheader) BackedgeBlocks.push_back(P);
|
|
|
|
}
|
2003-10-13 00:37:13 +00:00
|
|
|
|
|
|
|
// Create and insert the new backedge block...
|
2009-08-13 21:58:54 +00:00
|
|
|
BasicBlock *BEBlock = BasicBlock::Create(Header->getContext(),
|
|
|
|
Header->getName()+".backedge", F);
|
2008-04-06 20:25:17 +00:00
|
|
|
BranchInst *BETerminator = BranchInst::Create(Header, BEBlock);
|
2003-10-13 00:37:13 +00:00
|
|
|
|
2011-01-02 22:09:33 +00:00
|
|
|
DEBUG(dbgs() << "LoopSimplify: Inserting unique backedge block "
|
|
|
|
<< BEBlock->getName() << "\n");
|
2010-03-01 17:55:27 +00:00
|
|
|
|
2003-10-13 00:37:13 +00:00
|
|
|
// Move the new backedge block to right after the last backedge block.
|
|
|
|
Function::iterator InsertPos = BackedgeBlocks.back(); ++InsertPos;
|
|
|
|
F->getBasicBlockList().splice(InsertPos, F->getBasicBlockList(), BEBlock);
|
2005-04-21 23:48:37 +00:00
|
|
|
|
2003-10-13 00:37:13 +00:00
|
|
|
// Now that the block has been inserted into the function, create PHI nodes in
|
|
|
|
// the backedge block which correspond to any PHI nodes in the header block.
|
2004-09-28 02:40:37 +00:00
|
|
|
for (BasicBlock::iterator I = Header->begin(); isa<PHINode>(I); ++I) {
|
|
|
|
PHINode *PN = cast<PHINode>(I);
|
2011-03-30 11:28:46 +00:00
|
|
|
PHINode *NewPN = PHINode::Create(PN->getType(), BackedgeBlocks.size(),
|
|
|
|
PN->getName()+".be", BETerminator);
|
2005-03-25 06:37:22 +00:00
|
|
|
if (AA) AA->copyValue(PN, NewPN);
|
2003-10-13 00:37:13 +00:00
|
|
|
|
|
|
|
// Loop over the PHI node, moving all entries except the one for the
|
|
|
|
// preheader over to the new PHI node.
|
|
|
|
unsigned PreheaderIdx = ~0U;
|
|
|
|
bool HasUniqueIncomingValue = true;
|
|
|
|
Value *UniqueValue = 0;
|
|
|
|
for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
|
|
|
|
BasicBlock *IBB = PN->getIncomingBlock(i);
|
|
|
|
Value *IV = PN->getIncomingValue(i);
|
|
|
|
if (IBB == Preheader) {
|
|
|
|
PreheaderIdx = i;
|
|
|
|
} else {
|
|
|
|
NewPN->addIncoming(IV, IBB);
|
|
|
|
if (HasUniqueIncomingValue) {
|
|
|
|
if (UniqueValue == 0)
|
|
|
|
UniqueValue = IV;
|
|
|
|
else if (UniqueValue != IV)
|
|
|
|
HasUniqueIncomingValue = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2005-04-21 23:48:37 +00:00
|
|
|
|
2003-10-13 00:37:13 +00:00
|
|
|
// Delete all of the incoming values from the old PN except the preheader's
|
|
|
|
assert(PreheaderIdx != ~0U && "PHI has no preheader entry??");
|
|
|
|
if (PreheaderIdx != 0) {
|
|
|
|
PN->setIncomingValue(0, PN->getIncomingValue(PreheaderIdx));
|
|
|
|
PN->setIncomingBlock(0, PN->getIncomingBlock(PreheaderIdx));
|
|
|
|
}
|
2005-01-29 00:39:08 +00:00
|
|
|
// Nuke all entries except the zero'th.
|
|
|
|
for (unsigned i = 0, e = PN->getNumIncomingValues()-1; i != e; ++i)
|
|
|
|
PN->removeIncomingValue(e-i, false);
|
2003-10-13 00:37:13 +00:00
|
|
|
|
|
|
|
// Finally, add the newly constructed PHI node as the entry for the BEBlock.
|
|
|
|
PN->addIncoming(NewPN, BEBlock);
|
|
|
|
|
|
|
|
// As an optimization, if all incoming values in the new PhiNode (which is a
|
|
|
|
// subset of the incoming values of the old PHI node) have the same value,
|
|
|
|
// eliminate the PHI Node.
|
|
|
|
if (HasUniqueIncomingValue) {
|
|
|
|
NewPN->replaceAllUsesWith(UniqueValue);
|
2005-03-25 06:37:22 +00:00
|
|
|
if (AA) AA->deleteValue(NewPN);
|
2003-10-13 00:37:13 +00:00
|
|
|
BEBlock->getInstList().erase(NewPN);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now that all of the PHI nodes have been inserted and adjusted, modify the
|
2008-04-25 16:53:59 +00:00
|
|
|
// backedge blocks to just to the BEBlock instead of the header.
|
2003-10-13 00:37:13 +00:00
|
|
|
for (unsigned i = 0, e = BackedgeBlocks.size(); i != e; ++i) {
|
|
|
|
TerminatorInst *TI = BackedgeBlocks[i]->getTerminator();
|
|
|
|
for (unsigned Op = 0, e = TI->getNumSuccessors(); Op != e; ++Op)
|
|
|
|
if (TI->getSuccessor(Op) == Header)
|
|
|
|
TI->setSuccessor(Op, BEBlock);
|
|
|
|
}
|
|
|
|
|
|
|
|
//===--- Update all analyses which we must preserve now -----------------===//
|
|
|
|
|
|
|
|
// Update Loop Information - we know that this block is now in the current
|
|
|
|
// loop and all parent loops.
|
2007-11-27 03:43:35 +00:00
|
|
|
L->addBasicBlockToLoop(BEBlock, LI->getBase());
|
2003-10-13 00:37:13 +00:00
|
|
|
|
2007-06-21 17:23:45 +00:00
|
|
|
// Update dominator information
|
|
|
|
DT->splitBlock(BEBlock);
|
2009-11-05 21:14:46 +00:00
|
|
|
|
|
|
|
return BEBlock;
|
|
|
|
}
|
|
|
|
|
|
|
|
void LoopSimplify::verifyAnalysis() const {
|
|
|
|
// It used to be possible to just assert L->isLoopSimplifyForm(), however
|
|
|
|
// with the introduction of indirectbr, there are now cases where it's
|
|
|
|
// not possible to transform a loop as necessary. We can at least check
|
|
|
|
// that there is an indirectbr near any time there's trouble.
|
|
|
|
|
|
|
|
// Indirectbr can interfere with preheader and unique backedge insertion.
|
|
|
|
if (!L->getLoopPreheader() || !L->getLoopLatch()) {
|
|
|
|
bool HasIndBrPred = false;
|
|
|
|
for (pred_iterator PI = pred_begin(L->getHeader()),
|
|
|
|
PE = pred_end(L->getHeader()); PI != PE; ++PI)
|
|
|
|
if (isa<IndirectBrInst>((*PI)->getTerminator())) {
|
|
|
|
HasIndBrPred = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
assert(HasIndBrPred &&
|
|
|
|
"LoopSimplify has no excuse for missing loop header info!");
|
|
|
|
}
|
|
|
|
|
|
|
|
// Indirectbr can interfere with exit block canonicalization.
|
|
|
|
if (!L->hasDedicatedExits()) {
|
|
|
|
bool HasIndBrExiting = false;
|
|
|
|
SmallVector<BasicBlock*, 8> ExitingBlocks;
|
|
|
|
L->getExitingBlocks(ExitingBlocks);
|
|
|
|
for (unsigned i = 0, e = ExitingBlocks.size(); i != e; ++i)
|
|
|
|
if (isa<IndirectBrInst>((ExitingBlocks[i])->getTerminator())) {
|
|
|
|
HasIndBrExiting = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
assert(HasIndBrExiting &&
|
|
|
|
"LoopSimplify has no excuse for missing exit block info!");
|
|
|
|
}
|
2002-09-26 16:17:31 +00:00
|
|
|
}
|