6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-21 06:30:16 +00:00
Code Issues Projects Releases Wiki Activity

[x86 fast-isel] Materialize allocas with the correct-sized lea for ILP32

Browse Source 
Summary:
X86FastISel::fastMaterializeAlloca was incorrectly conditioning its
opcode selection on subtarget bitness rather than pointer size.

Differential Revision: http://reviews.llvm.org/D6136

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@221386 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Derek Schuff 2014-11-05 19:27:21 +00:00
parent e7a8e298fb
commit 07ffcb1007
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Target/X86/X86FastISel.cpp
View File

@ -3271,7 +3271,7 @@ unsigned X86FastISel::fastMaterializeAlloca(const AllocaInst *C) {
X86AddressMode AM;
if (!X86SelectAddress(C, AM))
return 0;
unsigned Opc = Subtarget->is64Bit() ? X86::LEA64r : X86::LEA32r;
unsigned Opc = TLI.getPointerTy() == MVT::i32 ? X86::LEA32r : X86::LEA64r;
const TargetRegisterClass* RC = TLI.getRegClassFor(TLI.getPointerTy());
unsigned ResultReg = createResultReg(RC);
addFullAddress(BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc,

14
test/CodeGen/X86/fast-isel-x32.ll Normal file
View File

@ -0,0 +1,14 @@
; RUN: llc < %s -mtriple=x86_64-linux-gnux32 -fast-isel -fast-isel-abort -regalloc=fast | FileCheck %s
; RUN: llc < %s -mtriple=x86_64-nacl -fast-isel -fast-isel-abort -regalloc=fast | FileCheck %s
; Test that alloca addresses are materialized with the right size instruction.
declare void @bar(i32* %arg)
; CHECK-LABEL: @foo
define void @foo() {
%a = alloca i32
; CHECK: leal {{.*}}, %edi
call void @bar(i32* %a)
ret void
}

10
test/CodeGen/X86/fast-isel-x86-64.ll
View File

@ -302,3 +302,13 @@ define void @test23(i8* noalias sret %result) {
}
declare i8* @foo23()
declare void @takesi32ptr(i32* %arg)
; CHECK-LABEL: allocamaterialize
define void @allocamaterialize() {
%a = alloca i32
; CHECK: leaq {{.*}}, %rdi
call void @takesi32ptr(i32* %a)
ret void
}