6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-09-30 04:56:49 +00:00
Code Issues Projects Releases Wiki Activity

tools: use references rather than out pointers in COFFDumper

Browse Source 
Switch to use references for parameters that are guaranteed to be non-null.
Simplifies the code a slight bit in preparation for another change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209603 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Saleem Abdulrasool 2014-05-25 20:26:33 +00:00
parent cec37248b2
commit 12d17f4375
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tools/llvm-readobj/COFFDumper.cpp
View File

@ -80,11 +80,8 @@ private:
void cacheRelocations();
error_code getSection(
const std::vector<RelocationRef> &Rels,
uint64_t Offset,
const coff_section **Section,
uint64_t *AddrPtr);
error_code getSection(const std::vector<RelocationRef> &Rels, uint64_t Offset,
const coff_section *&Section, uint64_t &AddrPtr);
typedef DenseMap<const coff_section*, std::vector<RelocationRef> > RelocMapTy;
@ -460,24 +457,17 @@ static std::string formatSymbol(const std::vector<RelocationRef> &Rels,
return Str.str();
}
error_code COFFDumper::getSection(
const std::vector<RelocationRef> &Rels, uint64_t Offset,
const coff_section **SectionPtr, uint64_t *AddrPtr) {
error_code COFFDumper::getSection(const std::vector<RelocationRef> &Rels,
uint64_t Offset,
const coff_section *&SectionPtr,
uint64_t &AddrPtr) {
SymbolRef Sym;
if (error_code EC = resolveSymbol(Rels, Offset, Sym))
return EC;
const coff_section *Section;
uint64_t Addr;
if (error_code EC = resolveSectionAndAddress(Obj, Sym, Section, Addr))
if (error_code EC = resolveSectionAndAddress(Obj, Sym, SectionPtr, AddrPtr))
return EC;
if (SectionPtr)
*SectionPtr = Section;
if (AddrPtr)
*AddrPtr = Addr;
return object_error::success;
}
@ -1063,7 +1053,7 @@ void COFFDumper::printRuntimeFunction(
const coff_section* XData = nullptr;
uint64_t UnwindInfoOffset = 0;
if (error(getSection(Rels, OffsetInSection + 8, &XData, &UnwindInfoOffset)))
if (error(getSection(Rels, OffsetInSection + 8, XData, UnwindInfoOffset)))
return;
ArrayRef<uint8_t> XContents;