define array_pod_sort in terms of operator< instead of my brain

damaged approximation.  This should fix it on big endian platforms
and on 64-bit.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60352 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2008-12-01 16:50:01 +00:00
parent aaffa05d0a
commit 545fc87454

View File

@ -222,18 +222,14 @@ inline size_t array_lengthof(T (&x)[N]) {
} }
/// array_pod_sort_comparator - This is helper function for array_pod_sort, /// array_pod_sort_comparator - This is helper function for array_pod_sort,
/// which does a memcmp of a specific size. /// which just uses operator< on T.
template<unsigned Size> template<typename T>
static inline int array_pod_sort_comparator(const void *P1, const void *P2) { static inline int array_pod_sort_comparator(const void *P1, const void *P2) {
if (Size == sizeof(char)) if (*reinterpret_cast<const T*>(P1) < *reinterpret_cast<const T*>(P2))
return *(const char*)P1 - *(const char*)P2; return -1;
if (Size == sizeof(int)) if (*reinterpret_cast<const T*>(P2) < *reinterpret_cast<const T*>(P1))
return *(const int*)P1 - *(const int*)P2; return 1;
if (Size == sizeof(long long)) return 0;
return *(const long long*)P1 - *(const long long*)P2;
if (Size == sizeof(intptr_t))
return *(intptr_t*)P1 - *(intptr_t*)P2;
return memcmp(P1, P2, Size);
} }
/// array_pod_sort - This sorts an array with the specified start and end /// array_pod_sort - This sorts an array with the specified start and end
@ -245,8 +241,8 @@ static inline int array_pod_sort_comparator(const void *P1, const void *P2) {
/// possible. /// possible.
/// ///
/// This function assumes that you have simple POD-like types that can be /// This function assumes that you have simple POD-like types that can be
/// compared with memcmp and can be moved with memcpy. If this isn't true, you /// compared with operator< and can be moved with memcpy. If this isn't true,
/// should use std::sort. /// you should use std::sort.
/// ///
/// NOTE: If qsort_r were portable, we could allow a custom comparator and /// NOTE: If qsort_r were portable, we could allow a custom comparator and
/// default to std::less. /// default to std::less.