The expression "SubclassData = (SubclassData & ~1) | (V) ? 1 : 0;" does not do what

was intended!  | has higher precedence than ?.  Caught by Visual Studio.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@36302 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jeff Cohen 2007-04-21 14:32:59 +00:00
parent 2330e4d4c4
commit 68c773cf19

View File

@ -246,7 +246,7 @@ public:
/// setVolatile - Specify whether this is a volatile load or not.
///
void setVolatile(bool V) { SubclassData = (SubclassData & ~1) | (V) ? 1 : 0; }
void setVolatile(bool V) { SubclassData = (SubclassData & ~1) | unsigned(V); }
virtual LoadInst *clone() const;
@ -311,7 +311,7 @@ public:
/// setVolatile - Specify whether this is a volatile load or not.
///
void setVolatile(bool V) { SubclassData = (SubclassData & ~1) | (V) ? 1 : 0; }
void setVolatile(bool V) { SubclassData = (SubclassData & ~1) | unsigned(V); }
/// Transparently provide more efficient getOperand methods.
Value *getOperand(unsigned i) const {