6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-07-21 18:29:45 +00:00
Code Issues Projects Releases Wiki Activity

Address some review comments on TargetRegistry.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@75753 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Dunbar 2009-07-15 07:09:29 +00:00
parent b5a8c08bb1
commit 73b3ec4134
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
include/llvm/Target/TargetRegistry.h
View File

@ -32,7 +32,11 @@ namespace llvm {
///
/// For registration purposes, this is a POD type so that targets can be
/// registered without the use of static constructors.
struct Target {
///
/// Targets should implement a single global instance of this class (which
/// will be zero initialized), and pass that instance to the TargetRegistry as
/// part of their initialization.
class Target {
private:
typedef unsigned (*TripleMatchQualityFnTy)(const std::string &TT);
typedef unsigned (*ModuleMatchQualityFnTy)(const Module &M);
@ -44,7 +48,7 @@ namespace llvm {
TargetMachine &,
bool);
friend class TargetRegistry;
friend struct TargetRegistry;
/// Next - The next registered target in the linked list, maintained by the
/// TargetRegistry.
@ -132,6 +136,10 @@ namespace llvm {
/// @{
/// RegisterTarget - Register the given target.
///
/// Clients are responsible for ensuring that registration doesn't occur
/// while another thread is attempting to access the registry. Typically
/// this is done by initializing all targets at program startup.
///
/// @param T - The target being registered.
/// @param Name - The target name. This should be a static string.
@ -153,6 +161,10 @@ namespace llvm {
/// RegisterTargetMachine - Register a TargetMachine implementation for the
/// given target.
///
/// Clients are responsible for ensuring that registration doesn't occur
/// while another thread is attempting to access the registry. Typically
/// this is done by initializing all targets at program startup.
///
/// @param T - The target being registered.
/// @param Fn - A function to construct a TargetMachine for the target.
static void RegisterTargetMachine(Target &T,
@ -164,6 +176,10 @@ namespace llvm {
/// RegisterAsmPrinter - Register an AsmPrinter implementation for the given
/// target.
///
/// Clients are responsible for ensuring that registration doesn't occur
/// while another thread is attempting to access the registry. Typically
/// this is done by initializing all targets at program startup.
///
/// @param T - The target being registered.
/// @param Fn - A function to construct an AsmPrinter for the target.
static void RegisterAsmPrinter(Target &T, Target::AsmPrinterCtorTy Fn) {

4
lib/Support/TargetRegistry.cpp
View File

@ -11,9 +11,7 @@
#include <cassert>
using namespace llvm;
// FIXME: Worry about locking? In general everything should be registered at
// startup.
// Clients are responsible for avoid race conditions in registration.
static Target *FirstTarget = 0;
const Target *