Check isDiscardableIfUnused, rather than hasLocalLinkage, when bumping

GlobalValue linkage up to ExternalLinkage in the ExtractGV pass. This
prevents linkonce and linkonce_odr symbols from being DCE'd.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@176459 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Lang Hames 2013-03-04 22:40:44 +00:00
parent 1ae08e0077
commit 880e8c0ad4
2 changed files with 26 additions and 3 deletions

View File

@ -60,7 +60,7 @@ namespace {
continue;
}
bool Local = I->hasLocalLinkage();
bool Local = I->isDiscardableIfUnused();
if (Local)
I->setVisibility(GlobalValue::HiddenVisibility);
@ -80,7 +80,7 @@ namespace {
continue;
}
bool Local = I->hasLocalLinkage();
bool Local = I->isDiscardableIfUnused();
if (Local)
I->setVisibility(GlobalValue::HiddenVisibility);
@ -97,7 +97,7 @@ namespace {
Module::alias_iterator CurI = I;
++I;
if (CurI->hasLocalLinkage()) {
if (CurI->isDiscardableIfUnused()) {
CurI->setVisibility(GlobalValue::HiddenVisibility);
CurI->setLinkage(GlobalValue::ExternalLinkage);
}

View File

@ -0,0 +1,23 @@
; RUN: llvm-extract -func foo -S < %s | FileCheck %s
; RUN: llvm-extract -delete -func foo -S < %s | FileCheck --check-prefix=DELETE %s
; Test that we don't convert weak_odr to external definitions.
; CHECK: @bar = external hidden global i32
; CHECK: define hidden i32* @foo() {
; CHECK-NEXT: ret i32* @bar
; CHECK-NEXT: }
; DELETE: @bar = hidden global i32 42
; DELETE: declare hidden i32* @foo()
@bar = linkonce global i32 42
define linkonce i32* @foo() {
ret i32* @bar
}
define void @g() {
call i32* @foo()
ret void
}