Make sure HoistInsertPosition finds a position that is dominated by all

inputs.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@155809 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2012-04-30 03:53:06 +00:00
parent 6610b1db55
commit 9719cf329b
2 changed files with 35 additions and 1 deletions

View File

@ -4140,7 +4140,7 @@ LSRInstance::HoistInsertPosition(BasicBlock::iterator IP,
// Attempt to find an insert position in the middle of the block,
// instead of at the end, so that it can be used for other expansions.
if (IDom == Inst->getParent() &&
(!BetterPos || DT.dominates(BetterPos, Inst)))
(!BetterPos || !DT.dominates(Inst, BetterPos)))
BetterPos = llvm::next(BasicBlock::iterator(Inst));
}
if (!AllDominate)

View File

@ -0,0 +1,34 @@
; RUN: opt < %s -loop-reduce -S | FileCheck %s
@d = common global i32 0, align 4
define void @fn2(i32 %x) nounwind uwtable {
entry:
br label %for.cond
for.cond:
%g.0 = phi i32 [ 0, %entry ], [ %dec, %for.cond ]
%tobool = icmp eq i32 %x, 0
%dec = add nsw i32 %g.0, -1
br i1 %tobool, label %for.cond, label %for.end
for.end:
; CHECK: %tmp1 = load i32* @d, align 4
; CHECK-NEXT: %tmp2 = load i32* @d, align 4
; CHECK-NEXT: %0 = sub i32 %tmp1, %tmp2
%tmp1 = load i32* @d, align 4
%add = add nsw i32 %tmp1, %g.0
%tmp2 = load i32* @d, align 4
%tobool26 = icmp eq i32 %x, 0
br i1 %tobool26, label %for.end5, label %for.body.lr.ph
for.body.lr.ph:
%tobool3 = icmp ne i32 %tmp2, %add
br label %for.end5
for.end5:
ret void
}