6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-09-30 19:55:11 +00:00
Code Issues Projects Releases Wiki Activity

Try to clarify this comment some.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152221 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-03-07 10:13:40 +00:00
parent a1eb50fe3d
commit b53a1d67b1
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/CodeGen/MachineInstr.cpp
View File

@ -1850,10 +1850,13 @@ MachineInstrExpressionTrait::getHashValue(const MachineInstr* const &MI) {
// MachineOperand, but currently that doesn't work because there are many
// different ideas of "equality" and thus different sets of information that
// contribute to the hash code. This one happens to want to take a specific
// subset. It's not clear that this routine uses the correct set of
// information, it would be good to somehow ensure this function is
// MachineInstr::isIdenticalTo with the 'IgnoreVRegDefs' filter look at the
// same bits.
// subset. And it's still not clear that this routine uses the *correct*
// subset of information when computing the hash code. The goal is to use the
// same inputs for the hash code here that MachineInstr::isIdenticalTo uses to
// test for equality when passed the 'IgnoreVRegDefs' filter flag. It would
// be very useful to factor the selection of relevant inputs out of the two
// functions and into a common routine, but it's not clear how that can be
// done.
SmallVector<size_t, 8> HashComponents;
HashComponents.reserve(MI->getNumOperands() + 1);
HashComponents.push_back(MI->getOpcode());