6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-11-01 15:11:24 +00:00
Code Issues Projects Releases Wiki Activity

ARM ldm/stm register lists can be out of order.

Browse Source 
It's not a good style idea, as the registers will be laid down in memory in
numerical order, not the order they're in the list, but it's legal. vldm/vstm
are stricter.

rdar://11064740

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152943 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jim Grosbach 2012-03-16 20:48:38 +00:00
parent 0ccae0b1f6
commit be7cf2b377
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/ARM/AsmParser/ARMAsmParser.cpp
View File

@ -2854,8 +2854,12 @@ parseRegisterList(SmallVectorImpl<MCParsedAsmOperand*> &Operands) {
if (!RC->contains(Reg)) if (!RC->contains(Reg))
return Error(RegLoc, "invalid register in register list"); return Error(RegLoc, "invalid register in register list");
// List must be monotonically increasing. // List must be monotonically increasing.
if (getARMRegisterNumbering(Reg) < getARMRegisterNumbering(OldReg)) if (getARMRegisterNumbering(Reg) < getARMRegisterNumbering(OldReg)) {
if (ARMMCRegisterClasses[ARM::GPRRegClassID].contains(Reg))
Warning(RegLoc, "register list not in ascending order");
else
return Error(RegLoc, "register list not in ascending order"); return Error(RegLoc, "register list not in ascending order");
}
if (getARMRegisterNumbering(Reg) == getARMRegisterNumbering(OldReg)) { if (getARMRegisterNumbering(Reg) == getARMRegisterNumbering(OldReg)) {
Warning(RegLoc, "duplicated register (" + RegTok.getString() + Warning(RegLoc, "duplicated register (" + RegTok.getString() +
") in register list"); ") in register list");

2
test/MC/ARM/diagnostics.s
View File

@ -216,7 +216,7 @@
@ Out of order STM registers @ Out of order STM registers
stmda sp!, {r5, r2} stmda sp!, {r5, r2}
@ CHECK-ERRORS: error: register list not in ascending order @ CHECK-ERRORS: warning: register list not in ascending order
@ CHECK-ERRORS: stmda sp!, {r5, r2} @ CHECK-ERRORS: stmda sp!, {r5, r2}
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^