6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-04-05 17:39:16 +00:00
Code Issues Projects Releases Wiki Activity

Inliner should not add callgraph edges for intrinsic calls (PR22857)

Browse Source 
The CallGraphNode function "addCalledFunction()" asserts that edges are not to intrinsics.

This patch makes sure that the Inliner does not add such an edge to the callgraph.

Fix for clang crash by assertion: https://llvm.org/bugs/show_bug.cgi?id=22857

Differential Revision: http://reviews.llvm.org/D8231



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@231927 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjay Patel 2015-03-11 15:12:32 +00:00
parent 756a12d0d1
commit c2e4231627
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Transforms/Utils/InlineFunction.cpp
View File

@ -693,8 +693,15 @@ static void UpdateCallGraphAfterInlining(CallSite CS,
// If the call was inlined, but then constant folded, there is no edge to
// add. Check for this case.
Instruction *NewCall = dyn_cast<Instruction>(VMI->second);
if (!NewCall) continue;
if (!NewCall)
continue;
// We do not treat intrinsic calls like real function calls because we
// expect them to become inline code; do not add an edge for an intrinsic.
CallSite CS = CallSite(NewCall);
if (CS && CS.getCalledFunction() && CS.getCalledFunction()->isIntrinsic())
continue;
// Remember that this call site got inlined for the client of
// InlineFunction.
IFI.InlinedCalls.push_back(NewCall);

30
test/Transforms/InstCombine/inline-intrinsic-assert.ll Normal file
View File

@ -0,0 +1,30 @@
; RUN: opt < %s -inline -instcombine -S | FileCheck %s
; PR22857: http://llvm.org/bugs/show_bug.cgi?id=22857
; The inliner should not add an edge to an intrinsic and
; then assert that it did not add an edge to an intrinsic!
define float @foo(float %f1) #0 {
%call = call float @bar(float %f1)
ret float %call
; CHECK-LABEL: @foo(
; CHECK-NEXT: call float @llvm.fabs.f32
; CHECK-NEXT: ret float
}
define float @bar(float %f1) #0 {
%call = call float @sqr(float %f1)
%call1 = call float @sqrtf(float %call) #0
ret float %call1
}
define float @sqr(float %f) #0 {
%mul = fmul fast float %f, %f
ret float %mul
}
declare float @sqrtf(float) #0
attributes #0 = { "unsafe-fp-math"="true" }